mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cover disable diagnostic from case with invalid syntax

Browse Source
This commit is contained in:
AmrDeveloper 2023-07-05 19:31:37 +02:00
parent fe65eabc81
commit 54e897368d
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
crates/ide-diagnostics/src/handlers/useless_braces.rs
View File

@ -1,6 +1,6 @@
use ide_db::{base_db::FileId, source_change::SourceChange}; use ide_db::{base_db::FileId, source_change::SourceChange};
use itertools::Itertools; use itertools::Itertools;
use syntax::{ast, AstNode, SyntaxKind, SyntaxNode}; use syntax::{ast, AstNode, SyntaxNode};
use text_edit::TextEdit; use text_edit::TextEdit;
use crate::{fix, Diagnostic, DiagnosticCode}; use crate::{fix, Diagnostic, DiagnosticCode};
@ -16,7 +16,7 @@ pub(crate) fn useless_braces(
let use_tree_list = ast::UseTreeList::cast(node.clone())?; let use_tree_list = ast::UseTreeList::cast(node.clone())?;
if let Some((single_use_tree,)) = use_tree_list.use_trees().collect_tuple() { if let Some((single_use_tree,)) = use_tree_list.use_trees().collect_tuple() {
// If there is a `self` inside the bracketed `use`, don't show diagnostic. // If there is a `self` inside the bracketed `use`, don't show diagnostic.
if single_use_tree.syntax().first_token().unwrap().kind() == SyntaxKind::SELF_KW { if single_use_tree.path()?.segment()?.self_token().is_some() {
return Some(()); return Some(());
} }
@ -53,7 +53,10 @@ pub(crate) fn useless_braces(
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use crate::tests::{check_diagnostics, check_fix}; use crate::{
tests::{check_diagnostics, check_diagnostics_with_config, check_fix},
DiagnosticsConfig,
};
#[test] #[test]
fn test_check_unnecessary_braces_in_use_statement() { fn test_check_unnecessary_braces_in_use_statement() {
@ -100,6 +103,16 @@ mod a {
mod a { mod a {
} }
"#,
);
let mut config = DiagnosticsConfig::test_sample();
config.disabled.insert("syntax-error".to_string());
check_diagnostics_with_config(
config,
r#"
mod a { pub mod b {} }
use a::{b::self};
"#, "#,
); );
check_fix( check_fix(