mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

downgrade to pedantic

Browse Source
This commit is contained in:
Andre Bogus 2023-11-28 22:31:24 +01:00
parent 58c53e8ea9
commit 54de78a212
4 changed files with 23 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
clippy_lints/src/methods/mod.rs
View File

@ -1145,8 +1145,10 @@ declare_clippy_lint! {
/// `str` as an argument, e.g., `_.split("x")`.
///
/// ### Why is this bad?
/// Performing these methods using a `char` can be faster than
/// using a `str` because it needs one less indirection.
/// While this can make a perf difference on some systems,
/// benchmarks have proven inconclusive. But at least using a
/// char literal makes it clear that we are looking at a single
/// character.
///
/// ### Known problems
/// Does not catch multi-byte unicode characters. This is by
@ -1165,7 +1167,7 @@ declare_clippy_lint! {
/// ```
#[clippy::version = "pre 1.29.0"]
pub SINGLE_CHAR_PATTERN,
perf,
pedantic,
"using a single-character str where a char could be used, e.g., `_.split(\"x\")`"
}

2
tests/ui/single_char_pattern.fixed
View File

@ -1,5 +1,5 @@
#![allow(clippy::needless_raw_strings, clippy::needless_raw_string_hashes, unused_must_use)]
#![warn(clippy::single_char_pattern)]
use std::collections::HashSet;
fn main() {

2
tests/ui/single_char_pattern.rs
View File

@ -1,5 +1,5 @@
#![allow(clippy::needless_raw_strings, clippy::needless_raw_string_hashes, unused_must_use)]
#![warn(clippy::single_char_pattern)]
use std::collections::HashSet;
fn main() {

62
tests/ui/single_char_pattern.stderr
View File

@ -7,24 +7,6 @@ LL | x.split("x");
= note: `-D clippy::single-char-pattern` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:13:13
|
LL | x.split("ß");
| ^^^ help: consider using a `char`: `'ß'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:14:13
|
LL | x.split("ℝ");
| ^^^ help: consider using a `char`: `'ℝ'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:15:13
|
LL | x.split("💣");
| ^^^^ help: consider using a `char`: `'💣'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:18:23
|
@ -140,106 +122,94 @@ LL | x.trim_end_matches("x");
| ^^^ help: consider using a `char`: `'x'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:37:20
|
LL | x.strip_prefix("x");
| ^^^ help: consider using a `char`: `'x'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:38:20
|
LL | x.strip_suffix("x");
| ^^^ help: consider using a `char`: `'x'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:39:15
--> tests/ui/single_char_pattern.rs:37:15
|
LL | x.replace("x", "y");
| ^^^ help: consider using a `char`: `'x'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:40:16
--> tests/ui/single_char_pattern.rs:38:16
|
LL | x.replacen("x", "y", 3);
| ^^^ help: consider using a `char`: `'x'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:42:13
--> tests/ui/single_char_pattern.rs:40:13
|
LL | x.split("\n");
| ^^^^ help: consider using a `char`: `'\n'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:43:13
--> tests/ui/single_char_pattern.rs:41:13
|
LL | x.split("'");
| ^^^ help: consider using a `char`: `'\''`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:44:13
--> tests/ui/single_char_pattern.rs:42:13
|
LL | x.split("\'");
| ^^^^ help: consider using a `char`: `'\''`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:46:13
--> tests/ui/single_char_pattern.rs:44:13
|
LL | x.split("\"");
| ^^^^ help: consider using a `char`: `'"'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:51:31
--> tests/ui/single_char_pattern.rs:49:31
|
LL | x.replace(';', ",").split(","); // issue #2978
| ^^^ help: consider using a `char`: `','`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:52:19
--> tests/ui/single_char_pattern.rs:50:19
|
LL | x.starts_with("\x03"); // issue #2996
| ^^^^^^ help: consider using a `char`: `'\x03'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:59:13
--> tests/ui/single_char_pattern.rs:57:13
|
LL | x.split(r"a");
| ^^^^ help: consider using a `char`: `'a'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:60:13
--> tests/ui/single_char_pattern.rs:58:13
|
LL | x.split(r#"a"#);
| ^^^^^^ help: consider using a `char`: `'a'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:61:13
--> tests/ui/single_char_pattern.rs:59:13
|
LL | x.split(r###"a"###);
| ^^^^^^^^^^ help: consider using a `char`: `'a'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:62:13
--> tests/ui/single_char_pattern.rs:60:13
|
LL | x.split(r###"'"###);
| ^^^^^^^^^^ help: consider using a `char`: `'\''`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:63:13
--> tests/ui/single_char_pattern.rs:61:13
|
LL | x.split(r###"#"###);
| ^^^^^^^^^^ help: consider using a `char`: `'#'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:65:13
--> tests/ui/single_char_pattern.rs:63:13
|
LL | x.split(r#"\"#);
| ^^^^^^ help: consider using a `char`: `'\\'`
error: single-character string constant used as pattern
--> tests/ui/single_char_pattern.rs:66:13
--> tests/ui/single_char_pattern.rs:64:13
|
LL | x.split(r"\");
| ^^^^ help: consider using a `char`: `'\\'`
error: aborting due to 40 previous errors
error: aborting due to 35 previous errors