complete items from module scope

crates/libeditor/src/completion.rs

@@ -8,7 +8,7 @@
 
 use {
     AtomEdit, find_node_at_offset,
-    scope::FnScopes,
+    scope::{FnScopes, ModuleScope},
 };
 
 #[derive(Debug)]
@@ -24,18 +24,27 @@ pub fn scope_completion(file: &File, offset: TextUnit) -> Option<Vec<CompletionI
         file.incremental_reparse(&edit)?
     };
     let name_ref = find_node_at_offset::<ast::NameRef>(file.syntax(), offset)?;
-    let fn_def = ancestors(name_ref.syntax()).filter_map(ast::FnDef::cast).next()?;
-    let scopes = FnScopes::new(fn_def);
-    Some(complete(name_ref, &scopes))
+    let mut res = Vec::new();
+    if let Some(fn_def) = ancestors(name_ref.syntax()).filter_map(ast::FnDef::cast).next() {
+        let scopes = FnScopes::new(fn_def);
+        complete_fn(name_ref, &scopes, &mut res);
+    }
+    if let Some(root) = ancestors(name_ref.syntax()).filter_map(ast::Root::cast).next() {
+        let scope = ModuleScope::new(root);
+        res.extend(
+            scope.entries().iter()
+                .map(|entry| CompletionItem { name: entry.name().to_string() })
+        )
+    }
+    Some(res)
 }
 
-fn complete(name_ref: ast::NameRef, scopes: &FnScopes) -> Vec<CompletionItem> {
-    scopes.scope_chain(name_ref.syntax())
-        .flat_map(|scope| scopes.entries(scope).iter())
-        .map(|entry| CompletionItem {
-            name: entry.name().to_string()
-        })
-        .collect()
+fn complete_fn(name_ref: ast::NameRef, scopes: &FnScopes, acc: &mut Vec<CompletionItem>) {
+    acc.extend(
+        scopes.scope_chain(name_ref.syntax())
+            .flat_map(|scope| scopes.entries(scope).iter())
+            .map(|entry| CompletionItem { name: entry.name().to_string() })
+    )
 }
 
 #[cfg(test)]
@@ -59,7 +68,8 @@ fn quux(x: i32) {
                 let z = ();
             }
             ", r#"[CompletionItem { name: "y" },
-                   CompletionItem { name: "x" }]"#);
+                   CompletionItem { name: "x" },
+                   CompletionItem { name: "quux" }]"#);
     }
 
     #[test]
@@ -75,7 +85,8 @@ fn quux() {
                 }
             }
             ", r#"[CompletionItem { name: "b" },
-                   CompletionItem { name: "a" }]"#);
+                   CompletionItem { name: "a" },
+                   CompletionItem { name: "quux" }]"#);
     }
 
     #[test]
@@ -86,6 +97,20 @@ fn quux() {
                     <|>
                 }
             }
-            ", r#"[CompletionItem { name: "x" }]"#);
+            ", r#"[CompletionItem { name: "x" },
+                   CompletionItem { name: "quux" }]"#);
+    }
+
+    #[test]
+    fn test_completion_mod_scope() {
+        do_check(r"
+            struct Foo;
+            enum Baz {}
+            fn quux() {
+                <|>
+            }
+            ", r#"[CompletionItem { name: "Foo" },
+                   CompletionItem { name: "Baz" },
+                   CompletionItem { name: "quux" }]"#);
     }
 }

crates/libeditor/src/lib.rs

@@ -18,7 +18,7 @@
 
 use libsyntax2::{
     File, TextUnit, TextRange, SyntaxNodeRef,
-    ast::{AstNode, NameOwner},
+    ast::{self, AstNode, NameOwner},
     algo::{walk, find_leaf_at_offset, ancestors},
     SyntaxKind::{self, *},
 };
@@ -126,8 +126,8 @@ pub fn syntax_tree(file: &File) -> String {
 }
 
 pub fn runnables(file: &File) -> Vec<Runnable> {
-    file.ast()
-        .functions()
+    walk::preorder(file.syntax())
+        .filter_map(ast::FnDef::cast)
         .filter_map(|f| {
             let name = f.name()?.text();
             let kind = if name == "main" {

crates/libeditor/src/scope/mod.rs

@@ -1,3 +1,8 @@
 mod fn_scope;
+mod mod_scope;
+
+pub use self::{
+    fn_scope::FnScopes,
+    mod_scope::ModuleScope,
+};
 
-pub use self::fn_scope::FnScopes;

crates/libeditor/src/scope/mod_scope.rs

@@ -0,0 +1,47 @@
+use libsyntax2::{
+    AstNode, SyntaxNode, SmolStr, ast
+};
+
+pub struct ModuleScope {
+    entries: Vec<Entry>,
+}
+
+impl ModuleScope {
+    pub fn new(m: ast::Root) -> ModuleScope {
+        let entries = m.items().filter_map(|item| {
+            match item {
+                ast::ModuleItem::StructDef(item) => Entry::new(item),
+                ast::ModuleItem::EnumDef(item) => Entry::new(item),
+                ast::ModuleItem::FnDef(item) => Entry::new(item),
+                ast::ModuleItem::TraitDef(item) => Entry::new(item),
+                ast::ModuleItem::ExternCrateItem(_) |
+                ast::ModuleItem::ImplItem(_) |
+                ast::ModuleItem::UseItem(_) => None
+            }
+        }).collect();
+
+        ModuleScope { entries }
+    }
+
+    pub fn entries(&self) -> &[Entry] {
+        self.entries.as_slice()
+    }
+}
+
+pub struct Entry {
+    name: SyntaxNode,
+}
+
+impl Entry {
+    fn new<'a>(item: impl ast::NameOwner<'a>) -> Option<Entry> {
+        let name = item.name()?;
+        Some(Entry { name: name.syntax().owned() })
+    }
+    pub fn name(&self) -> SmolStr {
+        self.ast().text()
+    }
+    fn ast(&self) -> ast::Name {
+        ast::Name::cast(self.name.borrowed()).unwrap()
+    }
+}
+

crates/libsyntax2/src/ast/generated.rs

@@ -1441,6 +1441,10 @@ fn syntax(self) -> SyntaxNodeRef<'a> { self.syntax }
 }
 
 impl<'a> Root<'a> {
+    pub fn items(self) -> impl Iterator<Item = ModuleItem<'a>> + 'a {
+        super::children(self)
+    }
+
     pub fn functions(self) -> impl Iterator<Item = FnDef<'a>> + 'a {
         super::children(self)
     }

crates/libsyntax2/src/grammar.ron

@@ -238,6 +238,7 @@ Grammar(
     ast: {
         "Root": (
             collections: [
+                ["items", "ModuleItem"],
                 ["functions", "FnDef"],
                 ["modules", "Module"],
             ]