mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(code fmt): Apply style suggestions from code review

Browse Source 
Co-authored-by: antoyo <antoyo@users.noreply.github.com>
This commit is contained in:
tempdragon 2024-02-29 01:10:51 +08:00 committed by GitHub
parent 09fd9087b6
commit 51cd5f1c78
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/context.rs
View File

@ -345,7 +345,7 @@ impl<'gcc, 'tcx> BackendTypes for CodegenCx<'gcc, 'tcx> {
type Funclet = (); // TODO(antoyo)
type DIScope = (); // TODO(antoyo)
type DILocation = Location<'gcc>; // TODO(antoyo)
type DILocation = Location<'gcc>;
type DIVariable = (); // TODO(antoyo)
}

10
src/debuginfo.rs
View File

@ -31,7 +31,7 @@ fn dbg_var_addr(
_indirect_offsets: &[Size],
_fragment: Option<Range<Size>>,
) {
// Not sure if this is correct, probably wrong but still keep it here.
// FIXME(tempdragon): Not sure if this is correct, probably wrong but still keep it here.
#[cfg(feature = "master")]
variable_alloca.set_location(dbg_loc);
}
@ -40,11 +40,10 @@ fn insert_reference_to_gdb_debug_scripts_section_global(&mut self) {
// TODO(antoyo): insert reference to gdb debug scripts section global.
}
/// Currently, this function is not yet implemented. It seems that the
/// FIXME(tempdragon): Currently, this function is not yet implemented. It seems that the
/// debug name and the mangled name should both be included in the LValues.
/// Besides, a function to get the rvalue type(m_is_lvalue) should also be included.
fn set_var_name(&mut self, _value: RValue<'gcc>, _name: &str) {
//unimplemented!();
}
fn set_dbg_loc(&mut self, dbg_loc: Self::DILocation) {
@ -213,7 +212,7 @@ fn extend_scope_to_file(
_scope_metadata: Self::DIScope,
_file: &SourceFile,
) -> Self::DIScope {
//unimplemented!();
// TODO(antoyo): implement.
}
fn debuginfo_finalize(&self) {
@ -238,7 +237,7 @@ fn dbg_scope_fn(
_fn_abi: &FnAbi<'tcx, Ty<'tcx>>,
_maybe_definition_llfn: Option<RValue<'gcc>>,
) -> Self::DIScope {
//unimplemented!();
// TODO(antoyo): implement.
}
fn dbg_loc(
@ -247,7 +246,6 @@ fn dbg_loc(
_inlined_at: Option<Self::DILocation>,
span: Span,
) -> Self::DILocation {
//unimplemented!();
let pos = span.lo();
let (file, line, col) = self.lookup_debug_loc(pos);
let loc = match &file.name {