mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

move lint directly into check_attrs

Browse Source
This commit is contained in:
lucarlig 2024-02-25 23:17:03 +04:00
parent ee50d5df90
commit 5152050c5f
2 changed files with 12 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
clippy_lints/src/doc/empty_docs.rs
View File

@ -1,20 +0,0 @@
use super::EMPTY_DOCS;
use clippy_utils::diagnostics::span_lint_and_help;
use rustc_ast::Attribute;
use rustc_lint::LateContext;
use rustc_resolve::rustdoc::{attrs_to_doc_fragments, span_of_fragments};
// TODO: Adjust the parameters as necessary
pub(super) fn check(cx: &LateContext<'_>, attrs: &[Attribute]) {
let (fragments, _) = attrs_to_doc_fragments(attrs.iter().map(|attr| (attr, None)), true);
if let Some(span) = span_of_fragments(&fragments) {
span_lint_and_help(
cx,
EMPTY_DOCS,
span,
"empty doc comment",
None,
"consider removing or filling it",
);
}
}

15
clippy_lints/src/doc/mod.rs
View File

@ -19,7 +19,8 @@ use rustc_middle::hir::nested_filter;
use rustc_middle::lint::in_external_macro; use rustc_middle::lint::in_external_macro;
use rustc_middle::ty::{self}; use rustc_middle::ty::{self};
use rustc_resolve::rustdoc::{ use rustc_resolve::rustdoc::{
add_doc_fragment, attrs_to_doc_fragments, main_body_opts, source_span_for_markdown_range, DocFragment, add_doc_fragment, attrs_to_doc_fragments, main_body_opts, source_span_for_markdown_range, span_of_fragments,
DocFragment,
}; };
use rustc_session::impl_lint_pass; use rustc_session::impl_lint_pass;
use rustc_span::edition::Edition; use rustc_span::edition::Edition;
@ -27,7 +28,6 @@ use rustc_span::{sym, Span};
use std::ops::Range; use std::ops::Range;
use url::Url; use url::Url;
mod empty_docs;
mod link_with_quotes; mod link_with_quotes;
mod markdown; mod markdown;
mod missing_headers; mod missing_headers;
@ -546,7 +546,16 @@ fn check_attrs(cx: &LateContext<'_>, valid_idents: &FxHashSet<String>, attrs: &[
doc.pop(); doc.pop();
if doc.trim().is_empty() { if doc.trim().is_empty() {
empty_docs::check(cx, attrs); if let Some(span) = span_of_fragments(&fragments) {
span_lint_and_help(
cx,
EMPTY_DOCS,
span,
"empty doc comment",
None,
"consider removing or filling it",
);
}
return Some(DocHeaders::default()); return Some(DocHeaders::default());
} }