mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge #6114

Browse Source 
6114: Improve grammar and fix code example in style guide r=kjeremy a=lnicola



Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
This commit is contained in:
bors[bot] 2020-10-01 19:36:33 +00:00 committed by GitHub
commit 505ff4070a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
docs/dev/style.md
View File

@ -197,7 +197,7 @@ fn frobnicate(walrus: Option<Walrus>) {
}
```
Avoid preconditions that spawn function boundaries:
Avoid preconditions that span across function boundaries:
```rust
@ -218,9 +218,8 @@ fn foo() {
}
// Not as good
fn is_string_literal(s: &str) -> Option<&str> {
fn is_string_literal(s: &str) -> bool {
s.starts_with('"') && s.ends_with('"')
Some()
}
fn foo() {
@ -231,8 +230,8 @@ fn foo() {
}
```
In the "Not as good" version, the precondition that `1` is a valid char boundary is checked in `is_string_literal` and utilized in `foo`.
In the "Good" version, precondition check and usage are checked in the same block, and then encoded in the types.
In the "Not as good" version, the precondition that `1` is a valid char boundary is checked in `is_string_literal` and used in `foo`.
In the "Good" version, the precondition check and usage are checked in the same block, and then encoded in the types.
# Early Returns