mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not suggest borrowing binding in pattern in let else

Browse Source 
Fix #104838.
This commit is contained in:
Esteban Küber 2022-12-08 09:31:57 -08:00
parent e46416eed6
commit 4f7c257fd8
4 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compiler/rustc_mir_build/src/build/block.rs
View File

@ -231,7 +231,7 @@ fn ast_block_stmts(
remainder_span,
pattern,
None,
Some((None, initializer_span)),
Some((Some(&destination), initializer_span)),
);
this.visit_primary_bindings(
pattern,

14
src/test/ui/by-move-pattern-binding.stderr
View File

@ -32,15 +32,19 @@ LL + if let E::Bar(identifier) = &s.x {
|
error[E0507]: cannot move out of a shared reference
--> $DIR/by-move-pattern-binding.rs:25:17
--> $DIR/by-move-pattern-binding.rs:25:31
|
LL | let &E::Bar(identifier) = &s.x else {
| ^^^^^^^^^^ move occurs because value has type `String`, which does not implement the `Copy` trait
| ---------- ^^^^
| |
| data moved here
| move occurs because `identifier` has type `String`, which does not implement the `Copy` trait
|
help: consider borrowing here
help: consider removing the borrow
|
LL - let &E::Bar(identifier) = &s.x else {
LL + let E::Bar(identifier) = &s.x else {
|
LL | let &E::Bar(&identifier) = &s.x else {
| +
error: aborting due to 3 previous errors

1
src/test/ui/suggestions/dont-suggest-ref/simple.rs
View File

@ -319,7 +319,6 @@ struct Testing {
fn testing(a: &Testing) {
let Some(_s) = a.a else {
//~^ ERROR cannot move
//~| HELP consider borrowing
return;
};
}

12
src/test/ui/suggestions/dont-suggest-ref/simple.stderr
View File

@ -902,15 +902,13 @@ LL | fn f4((&mut X(_t),): (&mut X,)) { }
| move occurs because `_t` has type `Y`, which does not implement the `Copy` trait
error[E0507]: cannot move out of `a.a` as enum variant `Some` which is behind a shared reference
--> $DIR/simple.rs:320:14
--> $DIR/simple.rs:320:20
|
LL | let Some(_s) = a.a else {
| ^^ move occurs because `a.a.0` has type `String`, which does not implement the `Copy` trait
|
help: consider borrowing here
|
LL | let Some(&_s) = a.a else {
| +
| -- ^^^
| |
| data moved here
| move occurs because `_s` has type `String`, which does not implement the `Copy` trait
error: aborting due to 61 previous errors