mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

OsStr eq_ignore_ascii_case takes arg by value

Browse Source 
Per a comment on #70516 this changes `eq_ignore_ascii_case` to take the generic parameter `S: AsRef<OsStr>` by value instead of by reference.

This is technically a breaking change to an unstable method. I think the only way it would break is if you called this method with an explicit type parameter, ie `my_os_str.eq_ignore_ascii_case::<str>("foo")` becomes `my_os_str.eq_ignore_ascii_case::<&str>("foo")`.

Besides that, I believe it is overall more flexible since it can now take an owned `OsString` for example.

If this change should be made in some other PR (like #80193) then please just close this.
This commit is contained in:
Tyler Ruckinger 2021-02-03 10:28:51 -05:00 committed by GitHub
parent 6ad11e2e25
commit 4d1efb751a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
library/std/src/ffi/os_str.rs
View File

@ -826,7 +826,7 @@ pub fn is_ascii(&self) -> bool {
/// assert!(!OsString::from("Ferrös").eq_ignore_ascii_case("FERRÖS")); /// assert!(!OsString::from("Ferrös").eq_ignore_ascii_case("FERRÖS"));
/// ``` /// ```
#[unstable(feature = "osstring_ascii", issue = "70516")] #[unstable(feature = "osstring_ascii", issue = "70516")]
pub fn eq_ignore_ascii_case<S: ?Sized + AsRef<OsStr>>(&self, other: &S) -> bool { pub fn eq_ignore_ascii_case<S: AsRef<OsStr>>(&self, other: S) -> bool {
self.inner.eq_ignore_ascii_case(&other.as_ref().inner) self.inner.eq_ignore_ascii_case(&other.as_ref().inner)
} }
} }