From 46c545c1ba7a859825b4760cbf6360f4d0a8e3de Mon Sep 17 00:00:00 2001 From: Zalathar Date: Mon, 16 Oct 2023 20:52:20 +1100 Subject: [PATCH] coverage: Rename `check_invoked_macro_name_span` to `maybe_push_macro_name_span` --- compiler/rustc_mir_transform/src/coverage/spans.rs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/compiler/rustc_mir_transform/src/coverage/spans.rs b/compiler/rustc_mir_transform/src/coverage/spans.rs index 506bcea0e39..2c5aeeee841 100644 --- a/compiler/rustc_mir_transform/src/coverage/spans.rs +++ b/compiler/rustc_mir_transform/src/coverage/spans.rs @@ -290,12 +290,12 @@ fn to_refined_spans(mut self) -> Vec { while self.next_coverage_span() { if self.some_prev.is_none() { debug!(" initial span"); - self.check_invoked_macro_name_span(); + self.maybe_push_macro_name_span(); } else if self.curr().is_mergeable(self.prev()) { debug!(" same bcb (and neither is a closure), merge with prev={:?}", self.prev()); let prev = self.take_prev(); self.curr_mut().merge_from(prev); - self.check_invoked_macro_name_span(); + self.maybe_push_macro_name_span(); // Note that curr.span may now differ from curr_original_span } else if self.prev_ends_before_curr() { debug!( @@ -305,7 +305,7 @@ fn to_refined_spans(mut self) -> Vec { ); let prev = self.take_prev(); self.push_refined_span(prev); - self.check_invoked_macro_name_span(); + self.maybe_push_macro_name_span(); } else if self.prev().is_closure { // drop any equal or overlapping span (`curr`) and keep `prev` to test again in the // next iter @@ -347,7 +347,7 @@ fn to_refined_spans(mut self) -> Vec { } } else { self.cutoff_prev_at_overlapping_curr(); - self.check_invoked_macro_name_span(); + self.maybe_push_macro_name_span(); } } @@ -399,7 +399,9 @@ fn push_refined_span(&mut self, covspan: CoverageSpan) { self.refined_spans.push(covspan) } - fn check_invoked_macro_name_span(&mut self) { + /// If `curr` is part of a new macro expansion, carve out and push a separate + /// span that ends just after the macro name and its subsequent `!`. + fn maybe_push_macro_name_span(&mut self) { if let Some(visible_macro) = self.curr().visible_macro(self.body_span) { if !self .prev_expn_span