diff --git a/src/librustc_trans/trans/intrinsic.rs b/src/librustc_trans/trans/intrinsic.rs index 91c7409182d..6d0f7746cad 100644 --- a/src/librustc_trans/trans/intrinsic.rs +++ b/src/librustc_trans/trans/intrinsic.rs @@ -361,12 +361,11 @@ pub fn trans_intrinsic_call<'a, 'blk, 'tcx>(mut bcx: Block<'blk, 'tcx>, } (_, "init") => { let tp_ty = *substs.types.get(FnSpace, 0); - let lltp_ty = type_of::arg_type_of(ccx, tp_ty); - if return_type_is_void(ccx, tp_ty) { - C_nil(ccx) - } else { - C_null(lltp_ty) + if !return_type_is_void(ccx, tp_ty) { + // Just zero out the stack slot. (See comment on base::memzero for explaination) + zero_mem(bcx, llresult, tp_ty); } + C_nil(ccx) } // Effectively no-ops (_, "uninit") | (_, "forget") => { diff --git a/src/test/run-pass/init-large-type.rs b/src/test/run-pass/init-large-type.rs new file mode 100644 index 00000000000..0534d0c054f --- /dev/null +++ b/src/test/run-pass/init-large-type.rs @@ -0,0 +1,25 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// Makes sure that zero-initializing large types is reasonably fast, +// Doing it incorrectly causes massive slowdown in LLVM during +// optimisation. + +#![feature(intrinsics)] + +extern "rust-intrinsic" { + pub fn init() -> T; +} + +const SIZE: usize = 1024 * 1024; + +fn main() { + let _memory: [u8; SIZE] = unsafe { init() }; +}