mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #101192 - TaKO8Ki:remove-path-string, r=compiler-errors

Browse Source 
Remove path string
This commit is contained in:
Yuki Okushi 2022-08-31 08:47:20 +09:00 committed by GitHub
commit 42a1901cf4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
compiler/rustc_infer/src/infer/error_reporting/mod.rs
View File

@ -2055,22 +2055,22 @@ fn suggest_as_ref_where_appropriate(
(exp_found.expected.kind(), exp_found.found.kind()) (exp_found.expected.kind(), exp_found.found.kind())
{ {
if let ty::Adt(found_def, found_substs) = *found_ty.kind() { if let ty::Adt(found_def, found_substs) = *found_ty.kind() {
let path_str = format!("{:?}", exp_def);
if exp_def == &found_def { if exp_def == &found_def {
let opt_msg = "you can convert from `&Option<T>` to `Option<&T>` using \
`.as_ref()`";
let result_msg = "you can convert from `&Result<T, E>` to \
`Result<&T, &E>` using `.as_ref()`";
let have_as_ref = &[ let have_as_ref = &[
("std::option::Option", opt_msg), (
("core::option::Option", opt_msg), sym::Option,
("std::result::Result", result_msg), "you can convert from `&Option<T>` to `Option<&T>` using \
("core::result::Result", result_msg), `.as_ref()`",
),
(
sym::Result,
"you can convert from `&Result<T, E>` to \
`Result<&T, &E>` using `.as_ref()`",
),
]; ];
if let Some(msg) = have_as_ref if let Some(msg) = have_as_ref.iter().find_map(|(name, msg)| {
.iter() self.tcx.is_diagnostic_item(*name, exp_def.did()).then_some(msg)
.find_map(|(path, msg)| (&path_str == path).then_some(msg)) }) {
{
let mut show_suggestion = true; let mut show_suggestion = true;
for (exp_ty, found_ty) in for (exp_ty, found_ty) in
iter::zip(exp_substs.types(), found_substs.types()) iter::zip(exp_substs.types(), found_substs.types())