mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #224 from rust-lang/feature/min-max-intrinsic

Browse Source 
Use intrinsic for min/max
This commit is contained in:
Caleb Zulawski 2022-01-13 20:22:00 -05:00 committed by GitHub
commit 41db15373a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/core_simd/src/intrinsics.rs
View File

@ -46,6 +46,10 @@ extern "platform-intrinsic" {
/// fabs /// fabs
pub(crate) fn simd_fabs<T>(x: T) -> T; pub(crate) fn simd_fabs<T>(x: T) -> T;
// minnum/maxnum
pub(crate) fn simd_fmin<T>(x: T, y: T) -> T;
pub(crate) fn simd_fmax<T>(x: T, y: T) -> T;
pub(crate) fn simd_eq<T, U>(x: T, y: T) -> U; pub(crate) fn simd_eq<T, U>(x: T, y: T) -> U;
pub(crate) fn simd_ne<T, U>(x: T, y: T) -> U; pub(crate) fn simd_ne<T, U>(x: T, y: T) -> U;
pub(crate) fn simd_lt<T, U>(x: T, y: T) -> U; pub(crate) fn simd_lt<T, U>(x: T, y: T) -> U;

12
crates/core_simd/src/vector/float.rs
View File

@ -141,11 +141,7 @@ macro_rules! impl_float_vector {
#[inline] #[inline]
#[must_use = "method returns a new vector and does not mutate the original value"] #[must_use = "method returns a new vector and does not mutate the original value"]
pub fn min(self, other: Self) -> Self { pub fn min(self, other: Self) -> Self {
// TODO consider using an intrinsic unsafe { intrinsics::simd_fmin(self, other) }
self.is_nan().select(
other,
self.lanes_ge(other).select(other, self)
)
} }
/// Returns the maximum of each lane. /// Returns the maximum of each lane.
@ -154,11 +150,7 @@ macro_rules! impl_float_vector {
#[inline] #[inline]
#[must_use = "method returns a new vector and does not mutate the original value"] #[must_use = "method returns a new vector and does not mutate the original value"]
pub fn max(self, other: Self) -> Self { pub fn max(self, other: Self) -> Self {
// TODO consider using an intrinsic unsafe { intrinsics::simd_fmax(self, other) }
self.is_nan().select(
other,
self.lanes_le(other).select(other, self)
)
} }
/// Restrict each lane to a certain interval unless it is NaN. /// Restrict each lane to a certain interval unless it is NaN.