Remove fixed todos

This commit is contained in:
bjorn3 2024-03-27 13:35:11 +00:00
parent a64387bb6b
commit 41246b2cf6

View File

@ -215,7 +215,6 @@ pub(crate) fn define_function<'tcx>(
entry.set(gimli::DW_AT_linkage_name, AttributeValue::StringRef(linkage_name_id));
}
// Gdb requires DW_AT_name. Otherwise the DW_TAG_subprogram is skipped.
// FIXME only include the function name and not the full mangled symbol
entry.set(gimli::DW_AT_name, AttributeValue::StringRef(name_id));
entry.set(gimli::DW_AT_decl_file, AttributeValue::FileIndex(Some(file_id)));
@ -225,8 +224,6 @@ pub(crate) fn define_function<'tcx>(
entry.set(gimli::DW_AT_external, AttributeValue::FlagPresent);
}
// FIXME set DW_AT_external as appropriate
FunctionDebugContext {
entry_id,
function_source_loc: (file_id, line, column),