mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify calculation of missing functions

Browse Source 
Asymptotically computing a set difference is faster but in the average
case we won't have more than ~10 functions. Also prefer not using hash
sets as these may yield nondeterministic results.
This commit is contained in:
Igor Matuszewski 2019-03-07 13:36:35 +01:00
parent 713975b1c1
commit 406343492c
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
crates/ra_assists/src/add_missing_impl_members.rs
View File

@ -1,5 +1,3 @@
use std::collections::HashSet;
use crate::{Assist, AssistId, AssistCtx};
use hir::Resolver;
@ -69,14 +67,9 @@ pub(crate) fn add_missing_impl_members(mut ctx: AssistCtx<impl HirDatabase>) ->
let trait_fns = trait_items.map(ImplItem::kind).filter_map(fn_def_opt).collect::<Vec<_>>();
let impl_fns = impl_items.map(ImplItem::kind).filter_map(fn_def_opt).collect::<Vec<_>>();
let trait_fn_names = trait_fns.iter().cloned().filter_map(def_name).collect::<HashSet<_>>();
let impl_fn_names = impl_fns.iter().cloned().filter_map(def_name).collect::<HashSet<_>>();
let missing_fn_names = trait_fn_names.difference(&impl_fn_names).collect::<HashSet<_>>();
let missing_fns: Vec<_> = trait_fns
.iter()
.cloned()
.filter(|t| def_name(t).map(|n| missing_fn_names.contains(&n)).unwrap_or(false))
.into_iter()
.filter(|t| impl_fns.iter().all(|i| def_name(i) != def_name(t)))
.collect();
if missing_fns.is_empty() {
return None;