diff --git a/src/librustrt/unwind.rs b/src/librustrt/unwind.rs index 9e6dff8a751..fbbc1a08fd9 100644 --- a/src/librustrt/unwind.rs +++ b/src/librustrt/unwind.rs @@ -61,6 +61,7 @@ use core::prelude::*; use alloc::boxed::Box; use collections::string::String; +use collections::str::StrAllocating; use collections::vec::Vec; use core::any::Any; use core::atomic; @@ -525,7 +526,8 @@ pub fn begin_unwind_fmt(msg: &fmt::Arguments, file_line: &(&'static str, uint)) let mut v = Vec::new(); let _ = write!(&mut VecWriter { v: &mut v }, "{}", msg); - begin_unwind_inner(box String::from_utf8(v).unwrap(), file_line) + let msg = box String::from_utf8_lossy(v.as_slice()).into_string(); + begin_unwind_inner(msg, file_line) } /// This is the entry point of unwinding for fail!() and assert!(). diff --git a/src/test/run-fail/fail-non-utf8.rs b/src/test/run-fail/fail-non-utf8.rs new file mode 100644 index 00000000000..88720b421e6 --- /dev/null +++ b/src/test/run-fail/fail-non-utf8.rs @@ -0,0 +1,26 @@ + +// Copyright 2013 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// Previously failed formating invalid utf8. +// cc #16877 + +// error-pattern:failed at 'hello�' + +struct Foo; +impl std::fmt::Show for Foo { + fn fmt(&self, fmtr:&mut std::fmt::Formatter) -> std::fmt::Result { + // Purge invalid utf8: 0xff + fmtr.write(&[104, 101, 108, 108, 111, 0xff]) + } +} +fn main() { + fail!("{}", Foo) +}