mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix comments based on review

Browse Source
This commit is contained in:
dylni 2021-03-16 22:17:49 -04:00
parent 922ccacc93
commit 35a2096538
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
library/alloc/src/collections/btree/search.rs
View File

@ -94,9 +94,8 @@ impl<BorrowType: marker::BorrowType, K, V> NodeRef<BorrowType, K, V, marker::Lea
K: Borrow<Q>, K: Borrow<Q>,
R: RangeBounds<Q>, R: RangeBounds<Q>,
{ {
// It might be unsound to inline these variables if this logic changes (#81138). // Inlining these variables should be avoided. We assume the bounds reported by `range`
// We assume the bounds reported by `range` remain the same, but // remain the same, but an adversarial implementation could change between calls (#81138).
// an adversarial implementation could change between calls
let (start, end) = (range.start_bound(), range.end_bound()); let (start, end) = (range.start_bound(), range.end_bound());
match (start, end) { match (start, end) {
(Bound::Excluded(s), Bound::Excluded(e)) if s == e => { (Bound::Excluded(s), Bound::Excluded(e)) if s == e => {
@ -114,8 +113,6 @@ impl<BorrowType: marker::BorrowType, K, V> NodeRef<BorrowType, K, V, marker::Lea
loop { loop {
let (lower_edge_idx, lower_child_bound) = self.find_lower_bound_index(lower_bound); let (lower_edge_idx, lower_child_bound) = self.find_lower_bound_index(lower_bound);
let (upper_edge_idx, upper_child_bound) = self.find_upper_bound_index(upper_bound); let (upper_edge_idx, upper_child_bound) = self.find_upper_bound_index(upper_bound);
// SAFETY: This panic is used for safety, so external impls can't be called here. The
// comparison is done with integers for that reason.
if lower_edge_idx > upper_edge_idx { if lower_edge_idx > upper_edge_idx {
panic!("Ord is ill-defined in BTreeMap range") panic!("Ord is ill-defined in BTreeMap range")
} }