mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3989 from RalfJung/ci

Browse Source 
CI workflow: tweak conclusion job
This commit is contained in:
Ralf Jung 2024-10-25 14:50:10 +00:00 committed by GitHub
commit 3432b91bbc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/tools/miri/.github/workflows/ci.yml vendored
View File

@ -34,7 +34,7 @@ jobs:
# The `style` job only runs on Linux; this makes sure the Windows-host-specific # The `style` job only runs on Linux; this makes sure the Windows-host-specific
# code is also covered by clippy. # code is also covered by clippy.
- name: Check clippy - name: Check clippy
if: matrix.os == 'windows-latest' if: ${{ matrix.os == 'windows-latest' }}
run: ./miri clippy -- -D warnings run: ./miri clippy -- -D warnings
- name: Test Miri - name: Test Miri
@ -58,14 +58,15 @@ jobs:
- name: rustdoc - name: rustdoc
run: RUSTDOCFLAGS="-Dwarnings" ./miri doc --document-private-items run: RUSTDOCFLAGS="-Dwarnings" ./miri doc --document-private-items
# Summary job for the merge queue.
# ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB!
# And they should be added below in `cron-fail-notify` as well.
conclusion: conclusion:
needs: [build, style] needs: [build, style]
# We need to ensure this job does *not* get skipped if its dependencies fail, # We need to ensure this job does *not* get skipped if its dependencies fail,
# because a skipped job is considered a success by GitHub. So we have to # because a skipped job is considered a success by GitHub. So we have to
# overwrite `if:`. We use `!cancelled()` to ensure the job does still not get run # overwrite `if:`. We use `!cancelled()` to ensure the job does still not get run
# when the workflow is canceled manually. # when the workflow is canceled manually.
#
# ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB!
if: ${{ !cancelled() }} if: ${{ !cancelled() }}
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
@ -86,7 +87,7 @@ jobs:
# ... and create a PR. # ... and create a PR.
pull-requests: write pull-requests: write
needs: [build, style] needs: [build, style]
if: github.event_name == 'schedule' && failure() if: ${{ github.event_name == 'schedule' && failure() }}
steps: steps:
# Send a Zulip notification # Send a Zulip notification
- name: Install zulip-send - name: Install zulip-send