mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make noop_method_call warn by default

Browse Source
This commit is contained in:
Deadbeef 2023-05-24 16:05:42 +00:00
parent cec34a43b1
commit 33ec4e4bb0
6 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
compiler/rustc_lint/src/noop_method_call.rs
View File

@ -18,7 +18,6 @@
///
/// ```rust
/// # #![allow(unused)]
/// #![warn(noop_method_call)]
/// struct Foo;
/// let foo = &Foo;
/// let clone: &Foo = foo.clone();
@ -34,7 +33,7 @@
/// calling `clone` on a `&T` where `T` does not implement clone, actually doesn't do anything
/// as references are copy. This lint detects these calls and warns the user about them.
pub NOOP_METHOD_CALL,
Allow,
Warn,
"detects the use of well-known noop methods"
}

2
tests/ui/issues/issue-11820.rs
View File

@ -1,6 +1,8 @@
// run-pass
// pretty-expanded FIXME #23616
#![allow(noop_method_call)]
struct NoClone;
fn main() {

1
tests/ui/lint/noop-method-call.rs
View File

@ -1,7 +1,6 @@
// check-pass
#![allow(unused)]
#![warn(noop_method_call)]
use std::borrow::Borrow;
use std::ops::Deref;

22
tests/ui/lint/noop-method-call.stderr
View File

@ -1,18 +1,14 @@
warning: call to `.clone()` on a reference in this situation does nothing
--> $DIR/noop-method-call.rs:16:71
--> $DIR/noop-method-call.rs:15:71
|
LL | let non_clone_type_ref_clone: &PlainType<u32> = non_clone_type_ref.clone();
| ^^^^^^^^ unnecessary method call
|
= note: the type `&PlainType<u32>` which `clone` is being called on is the same as the type returned from `clone`, so the method call does not do anything and can be removed
note: the lint level is defined here
--> $DIR/noop-method-call.rs:4:9
|
LL | #![warn(noop_method_call)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(noop_method_call)]` on by default
warning: using `.clone()` on a double reference, which returns `&CloneType<u32>` instead of cloning the inner type
--> $DIR/noop-method-call.rs:23:63
--> $DIR/noop-method-call.rs:22:63
|
LL | let clone_type_ref_clone: &CloneType<u32> = clone_type_ref.clone();
| ^^^^^^^^
@ -20,7 +16,7 @@ LL | let clone_type_ref_clone: &CloneType<u32> = clone_type_ref.clone();
= note: `#[warn(suspicious_double_ref_op)]` on by default
warning: call to `.deref()` on a reference in this situation does nothing
--> $DIR/noop-method-call.rs:27:63
--> $DIR/noop-method-call.rs:26:63
|
LL | let non_deref_type_deref: &PlainType<u32> = non_deref_type.deref();
| ^^^^^^^^ unnecessary method call
@ -28,13 +24,13 @@ LL | let non_deref_type_deref: &PlainType<u32> = non_deref_type.deref();
= note: the type `&PlainType<u32>` which `deref` is being called on is the same as the type returned from `deref`, so the method call does not do anything and can be removed
warning: using `.deref()` on a double reference, which returns `&PlainType<u32>` instead of dereferencing the inner type
--> $DIR/noop-method-call.rs:31:63
--> $DIR/noop-method-call.rs:30:63
|
LL | let non_deref_type_deref: &PlainType<u32> = non_deref_type.deref();
| ^^^^^^^^
warning: call to `.borrow()` on a reference in this situation does nothing
--> $DIR/noop-method-call.rs:35:66
--> $DIR/noop-method-call.rs:34:66
|
LL | let non_borrow_type_borrow: &PlainType<u32> = non_borrow_type.borrow();
| ^^^^^^^^^ unnecessary method call
@ -42,13 +38,13 @@ LL | let non_borrow_type_borrow: &PlainType<u32> = non_borrow_type.borrow();
= note: the type `&PlainType<u32>` which `borrow` is being called on is the same as the type returned from `borrow`, so the method call does not do anything and can be removed
warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type
--> $DIR/noop-method-call.rs:43:44
--> $DIR/noop-method-call.rs:42:44
|
LL | let _v: Vec<&str> = xs.iter().map(|x| x.clone()).collect(); // could use `*x` instead
| ^^^^^^^^
warning: call to `.clone()` on a reference in this situation does nothing
--> $DIR/noop-method-call.rs:48:19
--> $DIR/noop-method-call.rs:47:19
|
LL | non_clone_type.clone();
| ^^^^^^^^ unnecessary method call
@ -56,7 +52,7 @@ LL | non_clone_type.clone();
= note: the type `&PlainType<T>` which `clone` is being called on is the same as the type returned from `clone`, so the method call does not do anything and can be removed
warning: call to `.clone()` on a reference in this situation does nothing
--> $DIR/noop-method-call.rs:53:19
--> $DIR/noop-method-call.rs:52:19
|
LL | non_clone_type.clone();
| ^^^^^^^^ unnecessary method call

2
tests/ui/underscore-imports/cycle.rs
View File

@ -2,6 +2,8 @@
// check-pass
#![allow(noop_method_call)]
mod x {
pub use crate::y::*;
pub use std::ops::Deref as _;

1
tests/ui/underscore-imports/hygiene.rs
View File

@ -3,6 +3,7 @@
// check-pass
#![feature(decl_macro)]
#![allow(noop_method_call)]
mod x {
pub use std::ops::Deref as _;