mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update Applicability of rc_buffer from MachineApplicable to

Browse Source 
`Unspecified`
This commit is contained in:
royrustdev 2022-10-12 16:41:48 +05:30
parent 2d588175ca
commit 31006b4227
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
clippy_lints/src/types/rc_buffer.rs
View File

@ -9,6 +9,7 @@ use rustc_span::symbol::sym;
use super::RC_BUFFER; use super::RC_BUFFER;
pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_>, def_id: DefId) -> bool { pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_>, def_id: DefId) -> bool {
let app = Applicability::Unspecified;
if cx.tcx.is_diagnostic_item(sym::Rc, def_id) { if cx.tcx.is_diagnostic_item(sym::Rc, def_id) {
if let Some(alternate) = match_buffer_type(cx, qpath) { if let Some(alternate) = match_buffer_type(cx, qpath) {
span_lint_and_sugg( span_lint_and_sugg(
@ -18,7 +19,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
"usage of `Rc<T>` when T is a buffer type", "usage of `Rc<T>` when T is a buffer type",
"try", "try",
format!("Rc<{alternate}>"), format!("Rc<{alternate}>"),
Applicability::MachineApplicable, app,
); );
} else { } else {
let Some(ty) = qpath_generic_tys(qpath).next() else { return false }; let Some(ty) = qpath_generic_tys(qpath).next() else { return false };
@ -31,7 +32,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
Some(ty) => ty.span, Some(ty) => ty.span,
None => return false, None => return false,
}; };
let mut applicability = Applicability::MachineApplicable; let mut applicability = app;
span_lint_and_sugg( span_lint_and_sugg(
cx, cx,
RC_BUFFER, RC_BUFFER,
@ -42,7 +43,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
"Rc<[{}]>", "Rc<[{}]>",
snippet_with_applicability(cx, inner_span, "..", &mut applicability) snippet_with_applicability(cx, inner_span, "..", &mut applicability)
), ),
Applicability::MachineApplicable, app,
); );
return true; return true;
} }
@ -55,7 +56,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
"usage of `Arc<T>` when T is a buffer type", "usage of `Arc<T>` when T is a buffer type",
"try", "try",
format!("Arc<{alternate}>"), format!("Arc<{alternate}>"),
Applicability::MachineApplicable, app,
); );
} else if let Some(ty) = qpath_generic_tys(qpath).next() { } else if let Some(ty) = qpath_generic_tys(qpath).next() {
let Some(id) = path_def_id(cx, ty) else { return false }; let Some(id) = path_def_id(cx, ty) else { return false };
@ -67,7 +68,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
Some(ty) => ty.span, Some(ty) => ty.span,
None => return false, None => return false,
}; };
let mut applicability = Applicability::MachineApplicable; let mut applicability = app;
span_lint_and_sugg( span_lint_and_sugg(
cx, cx,
RC_BUFFER, RC_BUFFER,
@ -78,7 +79,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
"Arc<[{}]>", "Arc<[{}]>",
snippet_with_applicability(cx, inner_span, "..", &mut applicability) snippet_with_applicability(cx, inner_span, "..", &mut applicability)
), ),
Applicability::MachineApplicable, app,
); );
return true; return true;
} }