From 304c183d4fc35a487ac9d8cecf97aec8e3a33bc8 Mon Sep 17 00:00:00 2001 From: Oneirical Date: Wed, 8 May 2024 21:44:57 -0400 Subject: [PATCH] correct comments --- tests/run-make/alloc-no-oom-handling/Makefile | 2 +- tests/run-make/alloc-no-rc/Makefile | 2 +- tests/run-make/alloc-no-sync/Makefile | 2 +- tests/run-make/allocator-shim-circular-deps/Makefile | 4 +++- tests/run-make/archive-duplicate-names/Makefile | 3 ++- tests/run-make/c-dynamic-dylib/Makefile | 2 +- tests/run-make/c-dynamic-rlib/Makefile | 2 +- tests/run-make/c-link-to-rust-dylib/Makefile | 2 +- tests/run-make/c-link-to-rust-staticlib/Makefile | 2 +- tests/run-make/c-static-dylib/Makefile | 2 +- tests/run-make/c-static-rlib/Makefile | 2 +- tests/run-make/cdylib-dylib-linkage/Makefile | 2 +- tests/run-make/cdylib/Makefile | 2 +- tests/run-make/codegen-options-parsing/Makefile | 2 +- tests/run-make/compile-stdin/Makefile | 2 +- tests/run-make/compiler-lookup-paths-2/Makefile | 2 +- 16 files changed, 19 insertions(+), 16 deletions(-) diff --git a/tests/run-make/alloc-no-oom-handling/Makefile b/tests/run-make/alloc-no-oom-handling/Makefile index 2f053f4025b..7c3ae90b58d 100644 --- a/tests/run-make/alloc-no-oom-handling/Makefile +++ b/tests/run-make/alloc-no-oom-handling/Makefile @@ -1,4 +1,4 @@ -# This test verifies that the Rust compiler can still compile correctly when the unstable no_global_oom_handling feature is turned on, which disables global error handling in alloc. +# This test checks that alloc can still compile correctly when the unstable no_global_oom_handling feature is turned on. # See https://github.com/rust-lang/rust/pull/84266 include ../tools.mk diff --git a/tests/run-make/alloc-no-rc/Makefile b/tests/run-make/alloc-no-rc/Makefile index f7422dec3a5..fcfe1603b6c 100644 --- a/tests/run-make/alloc-no-rc/Makefile +++ b/tests/run-make/alloc-no-rc/Makefile @@ -1,4 +1,4 @@ -# This test verifies that the Rust compiler can still compile correctly when the unstable no_rc feature is turned on, which disables rc in alloc. +# This test checks that alloc can still compile correctly when the unstable no_rc feature is turned on. # See https://github.com/rust-lang/rust/pull/89891 include ../tools.mk diff --git a/tests/run-make/alloc-no-sync/Makefile b/tests/run-make/alloc-no-sync/Makefile index 16db6404fa2..997dbcf6603 100644 --- a/tests/run-make/alloc-no-sync/Makefile +++ b/tests/run-make/alloc-no-sync/Makefile @@ -1,4 +1,4 @@ -# This test verifies that the Rust compiler can still compile correctly when the unstable no_sync feature is turned on, which disables sync in alloc. +# This test checks that alloc can still compile correctly when the unstable no_sync feature is turned on. # See https://github.com/rust-lang/rust/pull/89891 include ../tools.mk diff --git a/tests/run-make/allocator-shim-circular-deps/Makefile b/tests/run-make/allocator-shim-circular-deps/Makefile index 04531503eab..f667e2e2ec2 100644 --- a/tests/run-make/allocator-shim-circular-deps/Makefile +++ b/tests/run-make/allocator-shim-circular-deps/Makefile @@ -1,4 +1,6 @@ -# This test intentionally creates a circular dependency, and checks if this causes the resurgence of the compiler bug linked below. +# This test is designed to intentionally introduce a circular dependency scenario to check that a specific compiler bug doesn't make a resurgence. +# The bug in question arose when at least one crate required a global allocator, and that crate was placed after the one defining it in the linker order. +# The generated symbols.o should not result in any linker errors. # See https://github.com/rust-lang/rust/issues/112715 # ignore-cross-compile diff --git a/tests/run-make/archive-duplicate-names/Makefile b/tests/run-make/archive-duplicate-names/Makefile index a9a3373ac56..207eee39299 100644 --- a/tests/run-make/archive-duplicate-names/Makefile +++ b/tests/run-make/archive-duplicate-names/Makefile @@ -1,4 +1,5 @@ -# This test reads two object archives with the same filename, and extracts each one to a unique location. This checks that the functionality of the linked PR is preserved. +# When two object archives with the same filename are present, an iterator is supposed to inspect each object, recognize the duplication and extract each one to a different directory. +# This test checks that this duplicate handling behaviour has not been broken. # See https://github.com/rust-lang/rust/pull/24439 # ignore-cross-compile diff --git a/tests/run-make/c-dynamic-dylib/Makefile b/tests/run-make/c-dynamic-dylib/Makefile index d99634ba09a..0d409640486 100644 --- a/tests/run-make/c-dynamic-dylib/Makefile +++ b/tests/run-make/c-dynamic-dylib/Makefile @@ -1,4 +1,4 @@ -# This test verifies that dynamic Rust linking with C does not encounter any errors, with dynamic dependencies given preference over static. +# This test checks that dynamic Rust linking with C does not encounter any errors, with dynamic dependencies given preference over static. # See https://github.com/rust-lang/rust/issues/10434 # ignore-cross-compile diff --git a/tests/run-make/c-dynamic-rlib/Makefile b/tests/run-make/c-dynamic-rlib/Makefile index 8e510dc3cdb..a64e89cc0dc 100644 --- a/tests/run-make/c-dynamic-rlib/Makefile +++ b/tests/run-make/c-dynamic-rlib/Makefile @@ -1,4 +1,4 @@ -# This test verifies that dynamic Rust linking with C does not encounter any errors, with static dependencies given preference over dynamic. (This is the default behaviour.) +# This test checks that dynamic Rust linking with C does not encounter any errors, with static dependencies given preference over dynamic. (This is the default behaviour.) # See https://github.com/rust-lang/rust/issues/10434 # ignore-cross-compile diff --git a/tests/run-make/c-link-to-rust-dylib/Makefile b/tests/run-make/c-link-to-rust-dylib/Makefile index 79b23eb3791..201f717ece4 100644 --- a/tests/run-make/c-link-to-rust-dylib/Makefile +++ b/tests/run-make/c-link-to-rust-dylib/Makefile @@ -1,4 +1,4 @@ -# This test verifies that C linking with Rust does not encounter any errors, with dynamic libraries. +# This test checks that C linking with Rust does not encounter any errors, with dynamic libraries. # See https://github.com/rust-lang/rust/issues/10434 # ignore-cross-compile diff --git a/tests/run-make/c-link-to-rust-staticlib/Makefile b/tests/run-make/c-link-to-rust-staticlib/Makefile index 71a632800d0..d36cc421c46 100644 --- a/tests/run-make/c-link-to-rust-staticlib/Makefile +++ b/tests/run-make/c-link-to-rust-staticlib/Makefile @@ -1,4 +1,4 @@ -# This test verifies that C linking with Rust does not encounter any errors, with static libraries. +# This test checks that C linking with Rust does not encounter any errors, with static libraries. # See https://github.com/rust-lang/rust/issues/10434 # ignore-cross-compile diff --git a/tests/run-make/c-static-dylib/Makefile b/tests/run-make/c-static-dylib/Makefile index b808f465217..05da1743c83 100644 --- a/tests/run-make/c-static-dylib/Makefile +++ b/tests/run-make/c-static-dylib/Makefile @@ -1,4 +1,4 @@ -# This test verifies that static Rust linking with C does not encounter any errors, with dynamic dependencies given preference over static. +# This test checks that static Rust linking with C does not encounter any errors, with dynamic dependencies given preference over static. # See https://github.com/rust-lang/rust/issues/10434 # ignore-cross-compile diff --git a/tests/run-make/c-static-rlib/Makefile b/tests/run-make/c-static-rlib/Makefile index 18a6b2bee07..298e432cdb8 100644 --- a/tests/run-make/c-static-rlib/Makefile +++ b/tests/run-make/c-static-rlib/Makefile @@ -1,4 +1,4 @@ -# This test verifies that static Rust linking with C does not encounter any errors, with static dependencies given preference over dynamic. (This is the default behaviour.) +# This test checks that static Rust linking with C does not encounter any errors, with static dependencies given preference over dynamic. (This is the default behaviour.) # See https://github.com/rust-lang/rust/issues/10434 # ignore-cross-compile diff --git a/tests/run-make/cdylib-dylib-linkage/Makefile b/tests/run-make/cdylib-dylib-linkage/Makefile index 9038941504b..db8393d3c05 100644 --- a/tests/run-make/cdylib-dylib-linkage/Makefile +++ b/tests/run-make/cdylib-dylib-linkage/Makefile @@ -1,4 +1,4 @@ -# This test verifies that cdylibs can link against dylibs as dependencies, after this restriction was disabled. +# This test checks that cdylibs can link against dylibs as dependencies, after this restriction was disabled. # See https://github.com/rust-lang/rust/commit/72aaa3a414d17aa0c4f19feafa5bab5f84b60e63 # ignore-cross-compile diff --git a/tests/run-make/cdylib/Makefile b/tests/run-make/cdylib/Makefile index 47a870ef087..2c6414c3255 100644 --- a/tests/run-make/cdylib/Makefile +++ b/tests/run-make/cdylib/Makefile @@ -1,4 +1,4 @@ -# When the cdylib crate type was added as a variation of dylib, it needed a test to verify its function. +# When the cdylib crate type was added as a variation of dylib, it needed a test to check its function. # See https://github.com/rust-lang/rust/pull/33553 # ignore-cross-compile diff --git a/tests/run-make/codegen-options-parsing/Makefile b/tests/run-make/codegen-options-parsing/Makefile index c4029f29d28..beaf233502b 100644 --- a/tests/run-make/codegen-options-parsing/Makefile +++ b/tests/run-make/codegen-options-parsing/Makefile @@ -1,4 +1,4 @@ -# This test intentionally feeds invalid inputs to codegen and checks if the error message outputs contain the expected strings. +# This test intentionally feeds invalid inputs to codegen and checks if the error message outputs contain specific helpful indications. # ignore-cross-compile include ../tools.mk diff --git a/tests/run-make/compile-stdin/Makefile b/tests/run-make/compile-stdin/Makefile index b325b6a6f87..b3d7cc777a0 100644 --- a/tests/run-make/compile-stdin/Makefile +++ b/tests/run-make/compile-stdin/Makefile @@ -1,4 +1,4 @@ -# When provided standard input piped directly into rustc, this test verifies that the compilation completes successfully and that the output can be executed. +# When provided standard input piped directly into rustc, this test checks that the compilation completes successfully and that the output can be executed. # See https://github.com/rust-lang/rust/pull/28805 # ignore-cross-compile diff --git a/tests/run-make/compiler-lookup-paths-2/Makefile b/tests/run-make/compiler-lookup-paths-2/Makefile index 1ad0e24b0eb..ecc0577384a 100644 --- a/tests/run-make/compiler-lookup-paths-2/Makefile +++ b/tests/run-make/compiler-lookup-paths-2/Makefile @@ -1,4 +1,4 @@ -# This test verifies that extern crate declarations in Cargo without a corresponding declaration in the manifest of a dependency are NOT allowed. +# This test checks that extern crate declarations in Cargo without a corresponding declaration in the manifest of a dependency are NOT allowed. # See https://github.com/rust-lang/rust/pull/21113 include ../tools.mk