Fix suggestion regression with incorrect syntactic combination of trait bounds
This commit is contained in:
parent
e5bb7d80d6
commit
2f15dfab0b
@ -599,7 +599,19 @@ fn suggest_restricting_param_bound(
|
||||
if let Some(proj_pred) = proj_pred {
|
||||
let ProjectionPredicate { projection_ty, term } = proj_pred.skip_binder();
|
||||
let item = self.tcx.associated_item(projection_ty.item_def_id);
|
||||
constraint.push_str(&format!("<{}={}>", item.name, term.to_string()));
|
||||
|
||||
// FIXME: this case overlaps with code in TyCtxt::note_and_explain_type_err.
|
||||
// That should be extracted into a helper function.
|
||||
if constraint.ends_with('>') {
|
||||
constraint = format!(
|
||||
"{}, {}={}>",
|
||||
&constraint[..constraint.len() - 1],
|
||||
item.name,
|
||||
term.to_string()
|
||||
);
|
||||
} else {
|
||||
constraint.push_str(&format!("<{}={}>", item.name, term.to_string()));
|
||||
}
|
||||
}
|
||||
|
||||
if suggest_constraining_type_param(
|
||||
|
8
src/test/ui/suggestions/issue-97677.fixed
Normal file
8
src/test/ui/suggestions/issue-97677.fixed
Normal file
@ -0,0 +1,8 @@
|
||||
// run-rustfix
|
||||
|
||||
fn add_ten<N: std::ops::Add<i32, Output=N>>(n: N) -> N {
|
||||
n + 10
|
||||
//~^ ERROR cannot add `{integer}` to `N`
|
||||
}
|
||||
|
||||
fn main() { add_ten(0); }
|
@ -1,6 +1,8 @@
|
||||
// run-rustfix
|
||||
|
||||
fn add_ten<N>(n: N) -> N {
|
||||
n + 10
|
||||
//~^ ERROR cannot add `{integer}` to `N`
|
||||
}
|
||||
|
||||
fn main() {}
|
||||
fn main() { add_ten(0); }
|
||||
|
@ -1,5 +1,5 @@
|
||||
error[E0369]: cannot add `{integer}` to `N`
|
||||
--> $DIR/issue-97677.rs:2:7
|
||||
--> $DIR/issue-97677.rs:4:7
|
||||
|
|
||||
LL | n + 10
|
||||
| - ^ -- {integer}
|
||||
@ -8,7 +8,7 @@ LL | n + 10
|
||||
|
|
||||
help: consider restricting type parameter `N`
|
||||
|
|
||||
LL | fn add_ten<N: std::ops::Add<i32><Output=N>>(n: N) -> N {
|
||||
LL | fn add_ten<N: std::ops::Add<i32, Output=N>>(n: N) -> N {
|
||||
| ++++++++++++++++++++++++++++++
|
||||
|
||||
error: aborting due to previous error
|
||||
|
Loading…
Reference in New Issue
Block a user