Only omit trailing comma if block doesn't come from macro expansion
This commit is contained in:
parent
2b646bd533
commit
2c3bb42ebd
@ -829,7 +829,13 @@ fn non_exhaustive_match<'p, 'tcx>(
|
||||
} else {
|
||||
" ".to_string()
|
||||
};
|
||||
let comma = if matches!(only.body.kind, hir::ExprKind::Block(..)) { "" } else { "," };
|
||||
let comma = if matches!(only.body.kind, hir::ExprKind::Block(..))
|
||||
&& only.span.ctxt() == only.body.span.ctxt()
|
||||
{
|
||||
""
|
||||
} else {
|
||||
","
|
||||
};
|
||||
suggestion = Some((
|
||||
only.span.shrink_to_hi(),
|
||||
format!("{}{}{} => todo!()", comma, pre_indentation, pattern),
|
||||
@ -837,8 +843,13 @@ fn non_exhaustive_match<'p, 'tcx>(
|
||||
}
|
||||
[.., prev, last] if prev.span.ctxt() == last.span.ctxt() => {
|
||||
if let Ok(snippet) = sm.span_to_snippet(prev.span.between(last.span)) {
|
||||
let comma =
|
||||
if matches!(last.body.kind, hir::ExprKind::Block(..)) { "" } else { "," };
|
||||
let comma = if matches!(last.body.kind, hir::ExprKind::Block(..))
|
||||
&& last.span.ctxt() == last.body.span.ctxt()
|
||||
{
|
||||
""
|
||||
} else {
|
||||
","
|
||||
};
|
||||
suggestion = Some((
|
||||
last.span.shrink_to_hi(),
|
||||
format!(
|
||||
|
14
src/test/ui/issue-94866.rs
Normal file
14
src/test/ui/issue-94866.rs
Normal file
@ -0,0 +1,14 @@
|
||||
macro_rules! m {
|
||||
() => {
|
||||
{}
|
||||
};
|
||||
}
|
||||
|
||||
enum Enum { A, B }
|
||||
|
||||
fn main() {
|
||||
match Enum::A {
|
||||
//~^ ERROR non-exhaustive patterns
|
||||
Enum::A => m!()
|
||||
}
|
||||
}
|
21
src/test/ui/issue-94866.stderr
Normal file
21
src/test/ui/issue-94866.stderr
Normal file
@ -0,0 +1,21 @@
|
||||
error[E0004]: non-exhaustive patterns: `B` not covered
|
||||
--> $DIR/issue-94866.rs:10:11
|
||||
|
|
||||
LL | match Enum::A {
|
||||
| ^^^^^^^ pattern `B` not covered
|
||||
|
|
||||
note: `Enum` defined here
|
||||
--> $DIR/issue-94866.rs:7:16
|
||||
|
|
||||
LL | enum Enum { A, B }
|
||||
| ---- ^ not covered
|
||||
= note: the matched value is of type `Enum`
|
||||
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
|
||||
|
|
||||
LL ~ Enum::A => m!(),
|
||||
LL + B => todo!()
|
||||
|
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
For more information about this error, try `rustc --explain E0004`.
|
@ -12,7 +12,7 @@ LL | struct Foo(isize, isize);
|
||||
= note: the matched value is of type `Foo`
|
||||
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
|
||||
|
|
||||
LL ~ Foo(2, b) => println!("{}", b)
|
||||
LL ~ Foo(2, b) => println!("{}", b),
|
||||
LL + Foo(_, _) => todo!()
|
||||
|
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user