mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #117082 - fortanix:raoul/fix_closure_inherit_target_feature_sgx, r=Mark-Simulacrum

Browse Source 
Fix closure-inherit-target-feature test for SGX platform

PR #116078 adds the `closure-inherit-target-feature.rs` test that checks the generated assembly code for closures. These checks explicitly check the presence of `ret` instructions. This is incompatible with the SGX target as it explicitly rewrites all `ret` instructions to mitigate LVI vulnerabilities of certain processors. This PR simply ignores these tests for the SGX platform.

cc: ```@jethrogb```
This commit is contained in:
Guillaume Gomez 2023-10-29 12:35:00 +01:00 committed by GitHub
commit 2b98ecd345
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/assembly/closure-inherit-target-feature.rs
View File

@ -1,4 +1,5 @@
// only-x86_64 // only-x86_64
// ignore-sgx Tests incompatible with LVI mitigations
// assembly-output: emit-asm // assembly-output: emit-asm
// make sure the feature is not enabled at compile-time // make sure the feature is not enabled at compile-time
// compile-flags: -C opt-level=3 -C target-feature=-sse4.1 -C llvm-args=-x86-asm-syntax=intel // compile-flags: -C opt-level=3 -C target-feature=-sse4.1 -C llvm-args=-x86-asm-syntax=intel