mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge #3389

Browse Source 
3389: Note vscode remote limitation when client install fails r=matklad a=not-much-io

Just adding a note about the limitation referenced in https://github.com/rust-analyzer/rust-analyzer/issues/2522/ 

Considered checking if this message is relevant in the context (is this remote?) but decided against it because of return on investment - seeing how fast vscode iterates this limitation might just disappear in the near future.

Also checked if there is a way to already do this which lead me to leaving a specifing question at https://github.com/microsoft/vscode-remote-release/issues/385 

Co-authored-by: nmio <kristo.koert@gmail.com>
This commit is contained in:
bors[bot] 2020-03-02 03:28:08 +00:00 committed by GitHub
commit 29bdd435fc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
xtask/src/install.rs
View File

@ -122,7 +122,8 @@ fn install_client(ClientOpt::VsCode: ClientOpt) -> Result<()> {
if !installed_extensions.contains("rust-analyzer") { if !installed_extensions.contains("rust-analyzer") {
bail!( bail!(
"Could not install the Visual Studio Code extension. \ "Could not install the Visual Studio Code extension. \
Please make sure you have at least NodeJS 12.x together with the latest version of VS Code installed and try again." Please make sure you have at least NodeJS 12.x together with the latest version of VS Code installed and try again. \
Note that installing via xtask install does not work for VS Code Remote, instead you’ll need to install the .vsix manually."
); );
} }