From 2863a8ba7a71f2ff1190fd02d2ff673521bd8a39 Mon Sep 17 00:00:00 2001 From: Robin Kruppe Date: Sat, 12 Dec 2015 00:07:42 +0100 Subject: [PATCH] dec2flt: Simplify imports and module surface The import has been unnecessarily complicated since ParseFloatError::Invalid is not longer used unqualified. The pfe_* functions do not need to be public any more since the only other use site, from_str_radix for floats, has been removed. --- src/libcore/num/dec2flt/mod.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libcore/num/dec2flt/mod.rs b/src/libcore/num/dec2flt/mod.rs index 55be4cd3191..7b01b950d63 100644 --- a/src/libcore/num/dec2flt/mod.rs +++ b/src/libcore/num/dec2flt/mod.rs @@ -97,7 +97,7 @@ use fmt; use str::FromStr; use self::parse::{parse_decimal, Decimal, Sign}; -use self::parse::ParseResult::{self, Valid, ShortcutToInf, ShortcutToZero}; +use self::parse::ParseResult::{Valid, Invalid, ShortcutToInf, ShortcutToZero}; use self::num::digits_to_big; use self::rawfp::RawFloat; @@ -183,11 +183,11 @@ impl fmt::Display for ParseFloatError { } } -pub fn pfe_empty() -> ParseFloatError { +fn pfe_empty() -> ParseFloatError { ParseFloatError { kind: FloatErrorKind::Empty } } -pub fn pfe_invalid() -> ParseFloatError { +fn pfe_invalid() -> ParseFloatError { ParseFloatError { kind: FloatErrorKind::Invalid } } @@ -211,7 +211,7 @@ fn dec2flt(s: &str) -> Result { Valid(decimal) => try!(convert(decimal)), ShortcutToInf => T::infinity(), ShortcutToZero => T::zero(), - ParseResult::Invalid => match s { + Invalid => match s { "inf" => T::infinity(), "NaN" => T::nan(), _ => { return Err(pfe_invalid()); }