From 267574c8dfce8c7e6cc910e18d280c278544df26 Mon Sep 17 00:00:00 2001 From: Niko Matsakis Date: Tue, 7 Nov 2017 05:54:31 -0500 Subject: [PATCH] convert TODO in traits into a FIXME --- src/librustc/traits/mod.rs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/librustc/traits/mod.rs b/src/librustc/traits/mod.rs index 0489a316cb3..9314c9d051d 100644 --- a/src/librustc/traits/mod.rs +++ b/src/librustc/traits/mod.rs @@ -538,11 +538,14 @@ pub fn normalize_param_env_or_error<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, let region_scope_tree = region::ScopeTree::default(); let free_regions = FreeRegionMap::new(); - // TODO We should really... do something with these. But as of - // this writing we were ignoring them, just without knowing - // it, and it would take some refactoring to stop doing so. - // (In particular, the needed methods currently live in - // regionck.) -nmatsakis + // FIXME. We should really... do something with these region + // obligations. But this call just continues the older + // behavior (i.e., doesn't cause any new bugs), and it would + // take some further refactoring to actually solve them. In + // particular, we would have to handle implied bounds + // properly, and that code is currently largely confined to + // regionck (though I made some efforts to extract it + // out). -nmatsakis let _ = infcx.ignore_region_obligations(body_id); infcx.resolve_regions_and_report_errors(region_context, ®ion_scope_tree, &free_regions);