From 24abef3689840ec2ad0bb6ccdbc7cbcfb3844a82 Mon Sep 17 00:00:00 2001
From: Lukas Kalbertodt <lukas.kalbertodt@gmail.com>
Date: Tue, 7 Aug 2018 23:09:08 +0200
Subject: [PATCH] Add and update tests for `IndexMut` help message

---
 .../ui/borrowck/index-mut-help.nll.stderr     | 22 +++++++++++++++
 src/test/ui/borrowck/index-mut-help.rs        | 24 ++++++++++++++++
 src/test/ui/borrowck/index-mut-help.stderr    | 28 +++++++++++++++++++
 src/test/ui/issue-41726.stderr                |  2 ++
 4 files changed, 76 insertions(+)
 create mode 100644 src/test/ui/borrowck/index-mut-help.nll.stderr
 create mode 100644 src/test/ui/borrowck/index-mut-help.rs
 create mode 100644 src/test/ui/borrowck/index-mut-help.stderr

diff --git a/src/test/ui/borrowck/index-mut-help.nll.stderr b/src/test/ui/borrowck/index-mut-help.nll.stderr
new file mode 100644
index 00000000000..cc058f1fde5
--- /dev/null
+++ b/src/test/ui/borrowck/index-mut-help.nll.stderr
@@ -0,0 +1,22 @@
+error[E0596]: cannot borrow data in a `&` reference as mutable
+  --> $DIR/index-mut-help.rs:21:5
+   |
+LL |     map["peter"].clear();           //~ ERROR
+   |     ^^^^^^^^^^^^ cannot borrow as mutable
+
+error[E0594]: cannot assign to data in a `&` reference
+  --> $DIR/index-mut-help.rs:22:5
+   |
+LL |     map["peter"] = "0".to_string(); //~ ERROR
+   |     ^^^^^^^^^^^^ cannot assign
+
+error[E0596]: cannot borrow data in a `&` reference as mutable
+  --> $DIR/index-mut-help.rs:23:13
+   |
+LL |     let _ = &mut map["peter"];      //~ ERROR
+   |             ^^^^^^^^^^^^^^^^^ cannot borrow as mutable
+
+error: aborting due to 3 previous errors
+
+Some errors occurred: E0594, E0596.
+For more information about an error, try `rustc --explain E0594`.
diff --git a/src/test/ui/borrowck/index-mut-help.rs b/src/test/ui/borrowck/index-mut-help.rs
new file mode 100644
index 00000000000..a4df0ced2f2
--- /dev/null
+++ b/src/test/ui/borrowck/index-mut-help.rs
@@ -0,0 +1,24 @@
+// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// When mutably indexing a type that implements `Index` but not `IndexMut`, a
+// special 'help' message is added to the output.
+
+
+fn main() {
+    use std::collections::HashMap;
+
+    let mut map = HashMap::new();
+    map.insert("peter", "23".to_string());
+
+    map["peter"].clear();           //~ ERROR
+    map["peter"] = "0".to_string(); //~ ERROR
+    let _ = &mut map["peter"];      //~ ERROR
+}
diff --git a/src/test/ui/borrowck/index-mut-help.stderr b/src/test/ui/borrowck/index-mut-help.stderr
new file mode 100644
index 00000000000..b8b35ed3ed3
--- /dev/null
+++ b/src/test/ui/borrowck/index-mut-help.stderr
@@ -0,0 +1,28 @@
+error[E0596]: cannot borrow immutable indexed content as mutable
+  --> $DIR/index-mut-help.rs:21:5
+   |
+LL |     map["peter"].clear();           //~ ERROR
+   |     ^^^^^^^^^^^^ cannot borrow as mutable
+   |
+   = help: trait `IndexMut` is required to modify indexed content, but it is not implemented for `std::collections::HashMap<&str, std::string::String>`
+
+error[E0594]: cannot assign to immutable indexed content
+  --> $DIR/index-mut-help.rs:22:5
+   |
+LL |     map["peter"] = "0".to_string(); //~ ERROR
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot borrow as mutable
+   |
+   = help: trait `IndexMut` is required to modify indexed content, but it is not implemented for `std::collections::HashMap<&str, std::string::String>`
+
+error[E0596]: cannot borrow immutable indexed content as mutable
+  --> $DIR/index-mut-help.rs:23:18
+   |
+LL |     let _ = &mut map["peter"];      //~ ERROR
+   |                  ^^^^^^^^^^^^ cannot borrow as mutable
+   |
+   = help: trait `IndexMut` is required to modify indexed content, but it is not implemented for `std::collections::HashMap<&str, std::string::String>`
+
+error: aborting due to 3 previous errors
+
+Some errors occurred: E0594, E0596.
+For more information about an error, try `rustc --explain E0594`.
diff --git a/src/test/ui/issue-41726.stderr b/src/test/ui/issue-41726.stderr
index 172309537bf..c79196e0140 100644
--- a/src/test/ui/issue-41726.stderr
+++ b/src/test/ui/issue-41726.stderr
@@ -3,6 +3,8 @@ error[E0596]: cannot borrow immutable indexed content as mutable
    |
 LL |         things[src.as_str()].sort(); //~ ERROR cannot borrow immutable
    |         ^^^^^^^^^^^^^^^^^^^^ cannot borrow as mutable
+   |
+   = help: trait `IndexMut` is required to modify indexed content, but it is not implemented for `std::collections::HashMap<std::string::String, std::vec::Vec<std::string::String>>`
 
 error: aborting due to previous error