mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #10226 - not-my-profile:module_name_repetitions-span, r=giraffate

Browse Source 
Improve span for module_name_repetitions

changelog: [`module_name_repetitions`]: Narrowed span to the identifier
This commit is contained in:
bors 2023-01-26 00:17:52 +00:00
commit 23ea47b7eb
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clippy_lints/src/enum_variants.rs
View File

@ -277,7 +277,7 @@ fn check_item(&mut self, cx: &LateContext<'_>, item: &Item<'_>) {
Some(c) if is_word_beginning(c) => span_lint(
cx,
MODULE_NAME_REPETITIONS,
item.span,
item.ident.span,
"item name starts with its containing module's name",
),
_ => (),
@ -287,7 +287,7 @@ fn check_item(&mut self, cx: &LateContext<'_>, item: &Item<'_>) {
span_lint(
cx,
MODULE_NAME_REPETITIONS,
item.span,
item.ident.span,
"item name ends with its containing module's name",
);
}

20
tests/ui/module_name_repetitions.stderr
View File

@ -1,34 +1,34 @@
error: item name starts with its containing module's name
--> $DIR/module_name_repetitions.rs:8:5
--> $DIR/module_name_repetitions.rs:8:12
|
LL | pub fn foo_bar() {}
| ^^^^^^^^^^^^^^^^^^^
| ^^^^^^^
|
= note: `-D clippy::module-name-repetitions` implied by `-D warnings`
error: item name ends with its containing module's name
--> $DIR/module_name_repetitions.rs:9:5
--> $DIR/module_name_repetitions.rs:9:12
|
LL | pub fn bar_foo() {}
| ^^^^^^^^^^^^^^^^^^^
| ^^^^^^^
error: item name starts with its containing module's name
--> $DIR/module_name_repetitions.rs:10:5
--> $DIR/module_name_repetitions.rs:10:16
|
LL | pub struct FooCake;
| ^^^^^^^^^^^^^^^^^^^
| ^^^^^^^
error: item name ends with its containing module's name
--> $DIR/module_name_repetitions.rs:11:5
--> $DIR/module_name_repetitions.rs:11:14
|
LL | pub enum CakeFoo {}
| ^^^^^^^^^^^^^^^^^^^
| ^^^^^^^
error: item name starts with its containing module's name
--> $DIR/module_name_repetitions.rs:12:5
--> $DIR/module_name_repetitions.rs:12:16
|
LL | pub struct Foo7Bar;
| ^^^^^^^^^^^^^^^^^^^
| ^^^^^^^
error: aborting due to 5 previous errors