mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid the overhead of select! when possible

Browse Source
This commit is contained in:
mo8it 2024-08-10 02:12:09 +02:00
parent 35903a22aa
commit 204fb5bd4d
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/tools/rust-analyzer/crates/vfs-notify/src/lib.rs
View File

@ -13,7 +13,7 @@
sync::atomic::AtomicUsize, sync::atomic::AtomicUsize,
}; };
use crossbeam_channel::{never, select, unbounded, Receiver, Sender}; use crossbeam_channel::{select, unbounded, Receiver, Sender};
use notify::{Config, EventKind, RecommendedWatcher, RecursiveMode, Watcher}; use notify::{Config, EventKind, RecommendedWatcher, RecursiveMode, Watcher};
use paths::{AbsPath, AbsPathBuf, Utf8PathBuf}; use paths::{AbsPath, AbsPathBuf, Utf8PathBuf};
use rayon::iter::{IndexedParallelIterator as _, IntoParallelIterator as _, ParallelIterator}; use rayon::iter::{IndexedParallelIterator as _, IntoParallelIterator as _, ParallelIterator};
@ -85,10 +85,13 @@ fn new(sender: loader::Sender) -> NotifyActor {
} }
fn next_event(&self, receiver: &Receiver<Message>) -> Option<Event> { fn next_event(&self, receiver: &Receiver<Message>) -> Option<Event> {
let watcher_receiver = self.watcher.as_ref().map(|(_, receiver)| receiver); let Some((_, watcher_receiver)) = &self.watcher else {
return receiver.recv().ok().map(Event::Message);
};
select! { select! {
recv(receiver) -> it => it.ok().map(Event::Message), recv(receiver) -> it => it.ok().map(Event::Message),
recv(watcher_receiver.unwrap_or(&never())) -> it => Some(Event::NotifyEvent(it.unwrap())), recv(watcher_receiver) -> it => Some(Event::NotifyEvent(it.unwrap())),
} }
} }