mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #127038 - BoxyUwU:reword_comment, r=camelid

Browse Source 
Update test comment

r? `@camelid`

Rewrote this comment since it mixed up a/b in one place and was generally a bit confusing
This commit is contained in:
Matthias Krüger 2024-06-30 18:25:33 +02:00 committed by GitHub
commit 1fac8de919
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/ui/const-generics/repeat_expr_hack_gives_right_generics.rs
View File

@ -1,14 +1,18 @@
// Given an anon const `a`: `{ N }` and some anon const `b` which references the // Given a const argument `a`: `{ N }` and some const argument `b` which references the
// first anon const: `{ [1; a] }`. `b` should not have any generics as it is not // first anon const like so: `{ [1; a] }`. The `b` anon const should not be allowed to use
// a simple `N` argument nor is it a repeat expr count. // any generic parameters as:
// - The anon const is not a simple bare parameter, e.g. `N`
// - The anon const is not the *length* of an array repeat expression, e.g. the `N` in `[1; N]`.
// //
// On the other hand `b` *is* a repeat expr count and so it should inherit its // On the other hand `a` *is* a const argument for the length of a repeat expression and
// parents generics as part of the `const_evaluatable_unchecked` fcw (#76200). // so it *should* inherit the generics declared on its parent definition. (This hack is
// introduced for backwards compatibility and is tracked in #76200)
// //
// In this specific case however `b`'s parent should be `a` and so it should wind // In this specific case `a`'s parent should be `b` which does not have any generics.
// up not having any generics after all. If `a` were to inherit its generics from // This means that even though `a` inherits generics from `b`, it still winds up not having
// the enclosing item then the reference to `a` from `b` would contain generic // access to any generic parameters. If `a` were to inherit its generics from the surrounding
// parameters not usable by `b` which would cause us to ICE. // function `foo` then the reference to `a` from `b` would contain generic parameters not usable
// by `b` which would cause us to ICE.
fn bar<const N: usize>() {} fn bar<const N: usize>() {}

2
tests/ui/const-generics/repeat_expr_hack_gives_right_generics.stderr
View File

@ -1,5 +1,5 @@
error: generic parameters may not be used in const operations error: generic parameters may not be used in const operations
--> $DIR/repeat_expr_hack_gives_right_generics.rs:16:17 --> $DIR/repeat_expr_hack_gives_right_generics.rs:20:17
| |
LL | bar::<{ [1; N] }>(); LL | bar::<{ [1; N] }>();
| ^ cannot perform const operation using `N` | ^ cannot perform const operation using `N`