[doc_markdown
] Recognize words followed by empty parenthesis ()
for quoting
This commit is contained in:
parent
2e96c74dce
commit
1f2ca8127c
@ -9,11 +9,21 @@
|
|||||||
use crate::doc::DOC_MARKDOWN;
|
use crate::doc::DOC_MARKDOWN;
|
||||||
|
|
||||||
pub fn check(cx: &LateContext<'_>, valid_idents: &FxHashSet<String>, text: &str, span: Span) {
|
pub fn check(cx: &LateContext<'_>, valid_idents: &FxHashSet<String>, text: &str, span: Span) {
|
||||||
for word in text.split(|c: char| c.is_whitespace() || c == '\'') {
|
for orig_word in text.split(|c: char| c.is_whitespace() || c == '\'') {
|
||||||
// Trim punctuation as in `some comment (see foo::bar).`
|
// Trim punctuation as in `some comment (see foo::bar).`
|
||||||
// ^^
|
// ^^
|
||||||
// Or even as in `_foo bar_` which is emphasized. Also preserve `::` as a prefix/suffix.
|
// Or even as in `_foo bar_` which is emphasized. Also preserve `::` as a prefix/suffix.
|
||||||
let mut word = word.trim_matches(|c: char| !c.is_alphanumeric() && c != ':');
|
let trim_pattern = |c: char| !c.is_alphanumeric() && c != ':';
|
||||||
|
let mut word = orig_word.trim_end_matches(trim_pattern);
|
||||||
|
|
||||||
|
// If word is immediately followed by `()`, claw it back.
|
||||||
|
if let Some(tmp_word) = orig_word.get(..word.len() + 2)
|
||||||
|
&& tmp_word.ends_with("()")
|
||||||
|
{
|
||||||
|
word = tmp_word;
|
||||||
|
}
|
||||||
|
|
||||||
|
word = word.trim_start_matches(trim_pattern);
|
||||||
|
|
||||||
// Remove leading or trailing single `:` which may be part of a sentence.
|
// Remove leading or trailing single `:` which may be part of a sentence.
|
||||||
if word.starts_with(':') && !word.starts_with("::") {
|
if word.starts_with(':') && !word.starts_with("::") {
|
||||||
@ -84,7 +94,7 @@ fn has_hyphen(s: &str) -> bool {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
if has_underscore(word) || word.contains("::") || is_camel_case(word) {
|
if has_underscore(word) || word.contains("::") || is_camel_case(word) || word.ends_with("()") {
|
||||||
let mut applicability = Applicability::MachineApplicable;
|
let mut applicability = Applicability::MachineApplicable;
|
||||||
|
|
||||||
span_lint_and_then(
|
span_lint_and_then(
|
||||||
|
@ -94,7 +94,7 @@ enum LengthComparison {
|
|||||||
|
|
||||||
/// Extracts parts out of a length comparison expression.
|
/// Extracts parts out of a length comparison expression.
|
||||||
///
|
///
|
||||||
/// E.g. for `v.len() > 5` this returns `Some((LengthComparison::IntLessThanLength, 5, `v.len()`))`
|
/// E.g. for `v.len() > 5` this returns `Some((LengthComparison::IntLessThanLength, 5, v.len()))`
|
||||||
fn len_comparison<'hir>(
|
fn len_comparison<'hir>(
|
||||||
bin_op: BinOp,
|
bin_op: BinOp,
|
||||||
left: &'hir Expr<'hir>,
|
left: &'hir Expr<'hir>,
|
||||||
|
@ -227,3 +227,6 @@ where [(); N.checked_next_power_of_two().unwrap()]: {
|
|||||||
|
|
||||||
/// this checks if the lowerCamelCase issue is fixed
|
/// this checks if the lowerCamelCase issue is fixed
|
||||||
fn issue_11568() {}
|
fn issue_11568() {}
|
||||||
|
|
||||||
|
/// There is no try (`do()` or `do_not()`).
|
||||||
|
fn parenthesized_word() {}
|
||||||
|
@ -227,3 +227,6 @@ fn new() -> Self {
|
|||||||
|
|
||||||
/// this checks if the lowerCamelCase issue is fixed
|
/// this checks if the lowerCamelCase issue is fixed
|
||||||
fn issue_11568() {}
|
fn issue_11568() {}
|
||||||
|
|
||||||
|
/// There is no try (do() or do_not()).
|
||||||
|
fn parenthesized_word() {}
|
||||||
|
@ -319,5 +319,27 @@ help: try
|
|||||||
LL | /// Foo \[bar\] \[baz\] \[qux\]. `DocMarkdownLint`
|
LL | /// Foo \[bar\] \[baz\] \[qux\]. `DocMarkdownLint`
|
||||||
| ~~~~~~~~~~~~~~~~~
|
| ~~~~~~~~~~~~~~~~~
|
||||||
|
|
||||||
error: aborting due to 29 previous errors
|
error: item in documentation is missing backticks
|
||||||
|
--> $DIR/doc-fixable.rs:231:22
|
||||||
|
|
|
||||||
|
LL | /// There is no try (do() or do_not()).
|
||||||
|
| ^^^^
|
||||||
|
|
|
||||||
|
help: try
|
||||||
|
|
|
||||||
|
LL | /// There is no try (`do()` or do_not()).
|
||||||
|
| ~~~~~~
|
||||||
|
|
||||||
|
error: item in documentation is missing backticks
|
||||||
|
--> $DIR/doc-fixable.rs:231:30
|
||||||
|
|
|
||||||
|
LL | /// There is no try (do() or do_not()).
|
||||||
|
| ^^^^^^^^
|
||||||
|
|
|
||||||
|
help: try
|
||||||
|
|
|
||||||
|
LL | /// There is no try (do() or `do_not()`).
|
||||||
|
| ~~~~~~~~~~
|
||||||
|
|
||||||
|
error: aborting due to 31 previous errors
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user