Merge #11345
11345: minor: fix a typo in the style guide r=Veykril a=WaffleLapkin An example of preferring `<`/`<=` over `>`/`>=` was using `>`. Co-authored-by: Waffle Maybe <waffle.lapkin@gmail.com>
This commit is contained in:
commit
1f0c20e8ba
@ -927,13 +927,13 @@ When doing multiple comparisons use `<`/`<=`, avoid `>`/`>=`.
|
||||
assert!(lo <= x && x <= hi);
|
||||
assert!(r1 < l2 || r2 < l1);
|
||||
assert!(x < y);
|
||||
assert!(x > 0);
|
||||
assert!(0 < x);
|
||||
|
||||
// BAD
|
||||
assert!(x >= lo && x <= hi);
|
||||
assert!(r1 < l2 || l1 > r2);
|
||||
assert!(y > x);
|
||||
assert!(0 > x);
|
||||
assert!(x > 0);
|
||||
```
|
||||
|
||||
**Rationale:** Less-then comparisons are more intuitive, they correspond spatially to [real line](https://en.wikipedia.org/wiki/Real_line).
|
||||
|
Loading…
Reference in New Issue
Block a user