mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #12326 - jonas-schievink:add-clippy-task-preset, r=jonas-schievink

Browse Source 
feat: Add "cargo clippy" task preset

We've had a couple of common presets in `Tasks: Run Task -> cargo -> cargo [check,build,test,...]` before. This PR adds `cargo clippy` to that list, which makes for a convenient way of occasionally running Clippy on your code without having to reconfigure the Check on Save command to clippy.

These presets all use the `cargo` task type that we provide, so diagnostics will show up in the editor. However, they don't go through the server-side parsing logic, so it's not possible to apply suggestions, and diagnostics are fairly "low-fidelity". It would be cool if we could somehow pass Cargo's JSON output through the LSP server and render it properly, for arbitrary tasks.

cc https://github.com/rust-lang/rust-analyzer/issues/12323
This commit is contained in:
bors 2022-05-20 13:36:59 +00:00
commit 1b65e00aea
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
editors/code/src/tasks.ts
View File

@ -32,6 +32,7 @@ class CargoTaskProvider implements vscode.TaskProvider {
const defs = [ const defs = [
{ command: "build", group: vscode.TaskGroup.Build }, { command: "build", group: vscode.TaskGroup.Build },
{ command: "check", group: vscode.TaskGroup.Build }, { command: "check", group: vscode.TaskGroup.Build },
{ command: "clippy", group: vscode.TaskGroup.Build },
{ command: "test", group: vscode.TaskGroup.Test }, { command: "test", group: vscode.TaskGroup.Test },
{ command: "clean", group: vscode.TaskGroup.Clean }, { command: "clean", group: vscode.TaskGroup.Clean },
{ command: "run", group: undefined }, { command: "run", group: undefined },