From 1a0a6132a8f4f3d54971c11c74035c5872a72a1f Mon Sep 17 00:00:00 2001
From: Yukang <moorekang@gmail.com>
Date: Fri, 6 Jan 2023 15:03:05 +0800
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
---
 .../src/fn_ctxt/suggestions.rs                | 27 ++++++++++---------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs b/compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs
index 991b0399542..236bdc60e67 100644
--- a/compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs
+++ b/compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs
@@ -1021,25 +1021,26 @@ pub(crate) fn suggest_clone_for_ref(
         expr_ty: Ty<'tcx>,
         expected_ty: Ty<'tcx>,
     ) -> bool {
-        if let ty::Ref(_, inner_ty, hir::Mutability::Not) = expr_ty.kind() &&
-            let Some(clone_trait_def) = self.tcx.lang_items().clone_trait() &&
-                expected_ty == *inner_ty &&
-                self
+        if let ty::Ref(_, inner_ty, hir::Mutability::Not) = expr_ty.kind()
+            && let Some(clone_trait_def) = self.tcx.lang_items().clone_trait()
+            && expected_ty == *inner_ty
+            && self
                 .infcx
                 .type_implements_trait(
                     clone_trait_def,
                     [self.tcx.erase_regions(expected_ty)],
                     self.param_env
                 )
-                .must_apply_modulo_regions() {
-                    diag.span_suggestion_verbose(
-                        expr.span.shrink_to_hi(),
-                        "consider using clone here",
-                        ".clone()",
-                        Applicability::MachineApplicable,
-                    );
-                    return true;
-                }
+                .must_apply_modulo_regions()
+          {
+              diag.span_suggestion_verbose(
+                  expr.span.shrink_to_hi(),
+                  "consider using clone here",
+                  ".clone()",
+                  Applicability::MachineApplicable,
+              );
+              return true;
+          }
         false
     }