From 1a0200ebc0802fc33ee8aad6f1e94ad71be19aa0 Mon Sep 17 00:00:00 2001
From: Martin Nordholts <martin.nordholts@codetale.se>
Date: Thu, 8 Feb 2024 10:42:39 +0100
Subject: [PATCH] large_assignments: Add copy variant of Box, Rc, Arc check

---
 .../large_assignments/copy_into_box_rc_arc.rs | 33 +++++++++++++++++++
 .../copy_into_box_rc_arc.stderr               | 25 ++++++++++++++
 ...arc_allowed.rs => move_into_box_rc_arc.rs} |  2 ++
 ...wed.stderr => move_into_box_rc_arc.stderr} |  6 ++--
 4 files changed, 63 insertions(+), 3 deletions(-)
 create mode 100644 tests/ui/lint/large_assignments/copy_into_box_rc_arc.rs
 create mode 100644 tests/ui/lint/large_assignments/copy_into_box_rc_arc.stderr
 rename tests/ui/lint/large_assignments/{box_rc_arc_allowed.rs => move_into_box_rc_arc.rs} (85%)
 rename tests/ui/lint/large_assignments/{box_rc_arc_allowed.stderr => move_into_box_rc_arc.stderr} (84%)

diff --git a/tests/ui/lint/large_assignments/copy_into_box_rc_arc.rs b/tests/ui/lint/large_assignments/copy_into_box_rc_arc.rs
new file mode 100644
index 00000000000..9ed7ae12752
--- /dev/null
+++ b/tests/ui/lint/large_assignments/copy_into_box_rc_arc.rs
@@ -0,0 +1,33 @@
+#![deny(large_assignments)]
+#![feature(large_assignments)]
+#![move_size_limit = "1000"]
+// build-fail
+// only-x86_64
+
+// edition:2018
+// compile-flags: -Zmir-opt-level=1
+
+use std::{sync::Arc, rc::Rc};
+
+fn main() {
+    let data = [0; 9999];
+
+    // Looking at --emit mir, we can see that all parameters below are passed by
+    // copy. But it requires at least mir-opt-level=1.
+    let _ = Arc::new(data); // OK!
+    let _ = Box::new(data); // OK!
+    let _ = Rc::new(data); // OK!
+    let _ = NotBox::new(data); //~ ERROR large_assignments
+}
+
+struct NotBox {
+    data: [u8; 9999],
+}
+
+impl NotBox {
+    fn new(data: [u8; 9999]) -> Self {
+        Self { //~ ERROR large_assignments
+            data,
+        }
+    }
+}
diff --git a/tests/ui/lint/large_assignments/copy_into_box_rc_arc.stderr b/tests/ui/lint/large_assignments/copy_into_box_rc_arc.stderr
new file mode 100644
index 00000000000..a8645a271e9
--- /dev/null
+++ b/tests/ui/lint/large_assignments/copy_into_box_rc_arc.stderr
@@ -0,0 +1,25 @@
+error: moving 9999 bytes
+  --> $DIR/copy_into_box_rc_arc.rs:20:25
+   |
+LL |     let _ = NotBox::new(data);
+   |                         ^^^^ value moved from here
+   |
+   = note: The current maximum size is 1000, but it can be customized with the move_size_limit attribute: `#![move_size_limit = "..."]`
+note: the lint level is defined here
+  --> $DIR/copy_into_box_rc_arc.rs:1:9
+   |
+LL | #![deny(large_assignments)]
+   |         ^^^^^^^^^^^^^^^^^
+
+error: moving 9999 bytes
+  --> $DIR/copy_into_box_rc_arc.rs:29:9
+   |
+LL | /         Self {
+LL | |             data,
+LL | |         }
+   | |_________^ value moved from here
+   |
+   = note: The current maximum size is 1000, but it can be customized with the move_size_limit attribute: `#![move_size_limit = "..."]`
+
+error: aborting due to 2 previous errors
+
diff --git a/tests/ui/lint/large_assignments/box_rc_arc_allowed.rs b/tests/ui/lint/large_assignments/move_into_box_rc_arc.rs
similarity index 85%
rename from tests/ui/lint/large_assignments/box_rc_arc_allowed.rs
rename to tests/ui/lint/large_assignments/move_into_box_rc_arc.rs
index 33113642023..b4862c482f0 100644
--- a/tests/ui/lint/large_assignments/box_rc_arc_allowed.rs
+++ b/tests/ui/lint/large_assignments/move_into_box_rc_arc.rs
@@ -10,6 +10,8 @@
 use std::{sync::Arc, rc::Rc};
 
 fn main() {
+    // Looking at --emit mir, we can see that all parameters below are passed
+    // with by move.
     let _ = Arc::new([0; 9999]); // OK!
     let _ = Box::new([0; 9999]); // OK!
     let _ = Rc::new([0; 9999]); // OK!
diff --git a/tests/ui/lint/large_assignments/box_rc_arc_allowed.stderr b/tests/ui/lint/large_assignments/move_into_box_rc_arc.stderr
similarity index 84%
rename from tests/ui/lint/large_assignments/box_rc_arc_allowed.stderr
rename to tests/ui/lint/large_assignments/move_into_box_rc_arc.stderr
index fefb3a9621b..3d7d5efee18 100644
--- a/tests/ui/lint/large_assignments/box_rc_arc_allowed.stderr
+++ b/tests/ui/lint/large_assignments/move_into_box_rc_arc.stderr
@@ -1,18 +1,18 @@
 error: moving 9999 bytes
-  --> $DIR/box_rc_arc_allowed.rs:16:25
+  --> $DIR/move_into_box_rc_arc.rs:18:25
    |
 LL |     let _ = NotBox::new([0; 9999]);
    |                         ^^^^^^^^^ value moved from here
    |
    = note: The current maximum size is 1000, but it can be customized with the move_size_limit attribute: `#![move_size_limit = "..."]`
 note: the lint level is defined here
-  --> $DIR/box_rc_arc_allowed.rs:1:9
+  --> $DIR/move_into_box_rc_arc.rs:1:9
    |
 LL | #![deny(large_assignments)]
    |         ^^^^^^^^^^^^^^^^^
 
 error: moving 9999 bytes
-  --> $DIR/box_rc_arc_allowed.rs:26:13
+  --> $DIR/move_into_box_rc_arc.rs:28:13
    |
 LL |             data,
    |             ^^^^ value moved from here