mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add antoyo in TODOs

Browse Source
This commit is contained in:
Antoni Boucher 2022-06-09 22:15:24 -04:00
parent a69770308c
commit 1777cdd644
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/intrinsic/simd.rs
View File

@ -216,7 +216,7 @@ macro_rules! require_simd {
let variable = bx.current_func().new_local(None, vector.get_type(), "new_vector"); let variable = bx.current_func().new_local(None, vector.get_type(), "new_vector");
bx.llbb().add_assignment(None, variable, vector); bx.llbb().add_assignment(None, variable, vector);
let lvalue = bx.context.new_vector_access(None, variable.to_rvalue(), index); let lvalue = bx.context.new_vector_access(None, variable.to_rvalue(), index);
// TODO: if simd_insert is constant, use BIT_REF. // TODO(antoyo): if simd_insert is constant, use BIT_REF.
bx.llbb().add_assignment(None, lvalue, value); bx.llbb().add_assignment(None, lvalue, value);
return Ok(variable.to_rvalue()); return Ok(variable.to_rvalue());
} }
@ -545,9 +545,9 @@ macro_rules! arith_unary {
}, },
(true, true) => { (true, true) => {
// Algorithm from: https://codereview.stackexchange.com/questions/115869/saturated-signed-addition // Algorithm from: https://codereview.stackexchange.com/questions/115869/saturated-signed-addition
// TODO: improve using conditional operators if possible. // TODO(antoyo): improve using conditional operators if possible.
let arg_type = lhs.get_type(); let arg_type = lhs.get_type();
// TODO: convert lhs and rhs to unsigned. // TODO(antoyo): convert lhs and rhs to unsigned.
let sum = lhs + rhs; let sum = lhs + rhs;
let vector_type = arg_type.dyncast_vector().expect("vector type"); let vector_type = arg_type.dyncast_vector().expect("vector type");
let unit = vector_type.get_num_units(); let unit = vector_type.get_num_units();
@ -581,7 +581,7 @@ macro_rules! arith_unary {
// negative of the right operand. Find a proper subtraction algorithm. // negative of the right operand. Find a proper subtraction algorithm.
let rhs = bx.context.new_unary_op(None, UnaryOp::Minus, arg_type, rhs); let rhs = bx.context.new_unary_op(None, UnaryOp::Minus, arg_type, rhs);
// TODO: convert lhs and rhs to unsigned. // TODO(antoyo): convert lhs and rhs to unsigned.
let sum = lhs + rhs; let sum = lhs + rhs;
let vector_type = arg_type.dyncast_vector().expect("vector type"); let vector_type = arg_type.dyncast_vector().expect("vector type");
let unit = vector_type.get_num_units(); let unit = vector_type.get_num_units();