mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge #10395

Browse Source 
10395: Add pub(super) along with pub(crate) and pub as a completion keyword r=lnicola a=azdavis

I've gotten used to typing `pc` in front of items to get `pub(crate)`, but recently I needed `pub(super)`. So I tried typing `ps` and it didn't work. Now it should!

Co-authored-by: Ariel Davis <ariel.z.davis@icloud.com>
This commit is contained in:
bors[bot] 2021-09-30 06:07:50 +00:00 committed by GitHub
commit 161a5e8724
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crates/ide_completion/src/completions/keyword.rs
View File

@ -64,6 +64,7 @@ pub(crate) fn complete_expr_keyword(acc: &mut Completions, ctx: &CompletionConte
&& (expects_item || ctx.expects_non_trait_assoc_item() || ctx.expect_field())
{
add_keyword("pub(crate)", "pub(crate)");
add_keyword("pub(super)", "pub(super)");
add_keyword("pub", "pub");
}

3
crates/ide_completion/src/tests/item.rs
View File

@ -87,6 +87,7 @@ fn after_struct_name() {
r"struct Struct $0",
expect![[r##"
kw pub(crate)
kw pub(super)
kw pub
kw unsafe
kw fn
@ -120,6 +121,7 @@ fn after_fn_name() {
r"fn func() $0",
expect![[r##"
kw pub(crate)
kw pub(super)
kw pub
kw unsafe
kw fn
@ -157,6 +159,7 @@ struct Foo {
"#,
expect![[r#"
kw pub(crate)
kw pub(super)
kw pub
"#]],
)

6
crates/ide_completion/src/tests/item_list.rs
View File

@ -14,6 +14,7 @@ fn in_mod_item_list() {
r#"mod tests { $0 }"#,
expect![[r##"
kw pub(crate)
kw pub(super)
kw pub
kw unsafe
kw fn
@ -45,6 +46,7 @@ fn in_source_file_item_list() {
r#"$0"#,
expect![[r##"
kw pub(crate)
kw pub(super)
kw pub
kw unsafe
kw fn
@ -77,6 +79,7 @@ fn in_item_list_after_attr() {
r#"#[attr] $0"#,
expect![[r#"
kw pub(crate)
kw pub(super)
kw pub
kw unsafe
kw fn
@ -161,6 +164,7 @@ fn in_impl_assoc_item_list() {
r#"impl Struct { $0 }"#,
expect![[r##"
kw pub(crate)
kw pub(super)
kw pub
kw unsafe
kw fn
@ -181,6 +185,7 @@ fn in_impl_assoc_item_list_after_attr() {
r#"impl Struct { #[attr] $0 }"#,
expect![[r#"
kw pub(crate)
kw pub(super)
kw pub
kw unsafe
kw fn
@ -230,6 +235,7 @@ impl Test for () {
"#,
expect![[r##"
kw pub(crate)
kw pub(super)
kw pub
kw unsafe
kw fn

1
crates/ide_completion/src/tests/type_pos.rs
View File

@ -44,6 +44,7 @@ struct Foo<'lt, T, const C: usize>(f$0);
"#,
expect![[r##"
kw pub(crate)
kw pub(super)
kw pub
kw self
kw super