mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #5672 - phansch:regression-test-env, r=yaahc

Browse Source 
Add regression test for `string_lit_as_bytes` issue

Closes #5619

Before the fix in https://github.com/rust-lang/rust/pull/72637, `string_lit_as_bytes` was incorrectly triggering on the `env!` macro. With the fix merged, this test makes sure that the lint is not triggering anymore.

changelog: none
This commit is contained in:
bors 2020-06-02 12:40:20 +00:00
commit 153ef1c76f
3 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/ui/string_lit_as_bytes.fixed
View File

@ -14,6 +14,8 @@ fn str_lit_as_bytes() {
let strify = stringify!(foobar).as_bytes();
let current_version = env!("CARGO_PKG_VERSION").as_bytes();
let includestr = include_bytes!("entry_unfixable.rs");
let _ = b"string with newline\t\n";

2
tests/ui/string_lit_as_bytes.rs
View File

@ -14,6 +14,8 @@ fn str_lit_as_bytes() {
let strify = stringify!(foobar).as_bytes();
let current_version = env!("CARGO_PKG_VERSION").as_bytes();
let includestr = include_str!("entry_unfixable.rs").as_bytes();
let _ = "string with newline\t\n".as_bytes();

4
tests/ui/string_lit_as_bytes.stderr
View File

@ -13,13 +13,13 @@ LL | let bs = r###"raw string with 3# plus " ""###.as_bytes();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `br###"raw string with 3# plus " ""###`
error: calling `as_bytes()` on `include_str!(..)`
--> $DIR/string_lit_as_bytes.rs:17:22
--> $DIR/string_lit_as_bytes.rs:19:22
|
LL | let includestr = include_str!("entry_unfixable.rs").as_bytes();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `include_bytes!(..)` instead: `include_bytes!("entry_unfixable.rs")`
error: calling `as_bytes()` on a string literal
--> $DIR/string_lit_as_bytes.rs:19:13
--> $DIR/string_lit_as_bytes.rs:21:13
|
LL | let _ = "string with newline/t/n".as_bytes();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"string with newline/t/n"`