From 12b069f43414f6bcc71bf4d77af05b3300797c1a Mon Sep 17 00:00:00 2001 From: Lukas Wirth Date: Thu, 6 Apr 2023 19:49:33 +0200 Subject: [PATCH] Move hir_def::keys to hir_def::dyn_map --- crates/hir-def/src/child_by_source.rs | 3 +-- crates/hir-def/src/dyn_map.rs | 2 ++ crates/hir-def/src/{ => dyn_map}/keys.rs | 0 crates/hir-def/src/generics.rs | 3 +-- crates/hir-def/src/lib.rs | 1 - .../mod.rs} | 0 crates/hir/src/semantics/source_to_def.rs | 8 +++++--- 7 files changed, 9 insertions(+), 8 deletions(-) rename crates/hir-def/src/{ => dyn_map}/keys.rs (100%) rename crates/hir-def/src/{macro_expansion_tests.rs => macro_expansion_tests/mod.rs} (100%) diff --git a/crates/hir-def/src/child_by_source.rs b/crates/hir-def/src/child_by_source.rs index 68b57acca2a..21180fcbdae 100644 --- a/crates/hir-def/src/child_by_source.rs +++ b/crates/hir-def/src/child_by_source.rs @@ -10,9 +10,8 @@ use syntax::ast::HasDocComments; use crate::{ db::DefDatabase, - dyn_map::DynMap, + dyn_map::{keys, DynMap}, item_scope::ItemScope, - keys, src::{HasChildSource, HasSource}, AdtId, AssocItemId, DefWithBodyId, EnumId, EnumVariantId, FieldId, ImplId, Lookup, MacroId, ModuleDefId, ModuleId, TraitId, VariantId, diff --git a/crates/hir-def/src/dyn_map.rs b/crates/hir-def/src/dyn_map.rs index 166aa04da04..63138aa6ad7 100644 --- a/crates/hir-def/src/dyn_map.rs +++ b/crates/hir-def/src/dyn_map.rs @@ -21,6 +21,8 @@ //! //! This is a work of fiction. Any similarities to Kotlin's `BindingContext` are //! a coincidence. +pub mod keys; + use std::{ hash::Hash, marker::PhantomData, diff --git a/crates/hir-def/src/keys.rs b/crates/hir-def/src/dyn_map/keys.rs similarity index 100% rename from crates/hir-def/src/keys.rs rename to crates/hir-def/src/dyn_map/keys.rs diff --git a/crates/hir-def/src/generics.rs b/crates/hir-def/src/generics.rs index e4912fa8a64..354b8fd0af4 100644 --- a/crates/hir-def/src/generics.rs +++ b/crates/hir-def/src/generics.rs @@ -20,8 +20,7 @@ use crate::{ body::{Expander, LowerCtx}, child_by_source::ChildBySource, db::DefDatabase, - dyn_map::DynMap, - keys, + dyn_map::{keys, DynMap}, src::{HasChildSource, HasSource}, type_ref::{LifetimeRef, TypeBound, TypeRef}, AdtId, ConstParamId, GenericDefId, HasModule, LifetimeParamId, LocalLifetimeParamId, diff --git a/crates/hir-def/src/lib.rs b/crates/hir-def/src/lib.rs index 9e1a52900e8..407ef4b4a78 100644 --- a/crates/hir-def/src/lib.rs +++ b/crates/hir-def/src/lib.rs @@ -24,7 +24,6 @@ pub mod per_ns; pub mod item_scope; pub mod dyn_map; -pub mod keys; pub mod item_tree; diff --git a/crates/hir-def/src/macro_expansion_tests.rs b/crates/hir-def/src/macro_expansion_tests/mod.rs similarity index 100% rename from crates/hir-def/src/macro_expansion_tests.rs rename to crates/hir-def/src/macro_expansion_tests/mod.rs diff --git a/crates/hir/src/semantics/source_to_def.rs b/crates/hir/src/semantics/source_to_def.rs index 68593411403..c50ffa4f8b7 100644 --- a/crates/hir/src/semantics/source_to_def.rs +++ b/crates/hir/src/semantics/source_to_def.rs @@ -14,7 +14,7 @@ //! expression, an item definition. //! //! Knowing only the syntax gives us relatively little info. For example, -//! looking at the syntax of the function we can realise that it is a part of an +//! looking at the syntax of the function we can realize that it is a part of an //! `impl` block, but we won't be able to tell what trait function the current //! function overrides, and whether it does that correctly. For that, we need to //! go from [`ast::Fn`] to [`crate::Function`], and that's exactly what this @@ -88,9 +88,11 @@ use base_db::FileId; use hir_def::{ child_by_source::ChildBySource, - dyn_map::DynMap, + dyn_map::{ + keys::{self, Key}, + DynMap, + }, hir::{BindingId, LabelId}, - keys::{self, Key}, AdtId, ConstId, ConstParamId, DefWithBodyId, EnumId, EnumVariantId, FieldId, FunctionId, GenericDefId, GenericParamId, ImplId, LifetimeParamId, MacroId, ModuleId, StaticId, StructId, TraitAliasId, TraitId, TypeAliasId, TypeParamId, UnionId, VariantId,