mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move exported check to check_fn to exit early

Browse Source
This commit is contained in:
Philipp Krones 2024-07-02 19:30:30 +02:00
parent 2da0edbdf1
commit 125c778d6d
No known key found for this signature in database
GPG Key ID: 1CA0DF2AF59D68A5
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
clippy_lints/src/needless_pass_by_ref_mut.rs
View File

@ -138,6 +138,10 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessPassByRefMut<'tcx> {
return; return;
} }
if self.avoid_breaking_exported_api && cx.effective_visibilities.is_exported(fn_def_id) {
return;
}
let hir_id = cx.tcx.local_def_id_to_hir_id(fn_def_id); let hir_id = cx.tcx.local_def_id_to_hir_id(fn_def_id);
let is_async = match kind { let is_async = match kind {
FnKind::ItemFn(.., header) => { FnKind::ItemFn(.., header) => {
@ -262,11 +266,6 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessPassByRefMut<'tcx> {
.iter() .iter()
.filter(|(def_id, _)| !self.used_fn_def_ids.contains(def_id)) .filter(|(def_id, _)| !self.used_fn_def_ids.contains(def_id))
{ {
let is_exported = cx.effective_visibilities.is_exported(*fn_def_id);
if self.avoid_breaking_exported_api && is_exported {
continue;
}
let mut is_cfged = None; let mut is_cfged = None;
for input in unused { for input in unused {
// If the argument is never used mutably, we emit the warning. // If the argument is never used mutably, we emit the warning.
@ -286,7 +285,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessPassByRefMut<'tcx> {
format!("&{}", snippet(cx, cx.tcx.hir().span(inner_ty.ty.hir_id), "_"),), format!("&{}", snippet(cx, cx.tcx.hir().span(inner_ty.ty.hir_id), "_"),),
Applicability::Unspecified, Applicability::Unspecified,
); );
if is_exported { if cx.effective_visibilities.is_exported(*fn_def_id) {
diag.warn("changing this function will impact semver compatibility"); diag.warn("changing this function will impact semver compatibility");
} }
if *is_cfged { if *is_cfged {