mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix ICE caused by missing span in a region error

Browse Source
This commit is contained in:
Gurinder Singh 2024-09-09 12:27:36 +05:30
parent 59d4114b2d
commit 0f8efb3b5c
3 changed files with 70 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
compiler/rustc_trait_selection/src/error_reporting/infer/region.rs
View File

@ -625,11 +625,19 @@ pub(super) fn report_placeholder_failure(
if let ObligationCauseCode::WhereClause(_, span)
| ObligationCauseCode::WhereClauseInExpr(_, span, ..) =
&trace.cause.code().peel_derives()
&& !span.is_dummy()
{
let span = *span;
self.report_concrete_failure(generic_param_scope, placeholder_origin, sub, sup)
.with_span_note(span, "the lifetime requirement is introduced here")
let mut err = self.report_concrete_failure(
generic_param_scope,
placeholder_origin,
sub,
sup,
);
if !span.is_dummy() {
err =
err.with_span_note(span, "the lifetime requirement is introduced here");
}
err
} else {
unreachable!(
"control flow ensures we have a `BindingObligation` or `WhereClauseInExpr` here..."

18
tests/ui/wf/ice-wf-missing-span-in-error-130012.rs Normal file
View File

@ -0,0 +1,18 @@
// Regression test for ICE #130012
// Checks that we do not ICE while reporting
// lifetime mistmatch error
trait Fun {
type Assoc;
}
trait MyTrait: for<'a> Fun<Assoc = &'a ()> {}
//~^ ERROR binding for associated type `Assoc` references lifetime `'a`, which does not appear in the trait input types
//~| ERROR binding for associated type `Assoc` references lifetime `'a`, which does not appear in the trait input types
//~| ERROR binding for associated type `Assoc` references lifetime `'a`, which does not appear in the trait input types
impl<F: for<'b> Fun<Assoc = &'b ()>> MyTrait for F {}
//~^ ERROR binding for associated type `Assoc` references lifetime `'b`, which does not appear in the trait input types
//~| ERROR mismatched types
fn main() {}

41
tests/ui/wf/ice-wf-missing-span-in-error-130012.stderr Normal file
View File

@ -0,0 +1,41 @@
error[E0582]: binding for associated type `Assoc` references lifetime `'a`, which does not appear in the trait input types
--> $DIR/ice-wf-missing-span-in-error-130012.rs:9:28
|
LL | trait MyTrait: for<'a> Fun<Assoc = &'a ()> {}
| ^^^^^^^^^^^^^^
error[E0582]: binding for associated type `Assoc` references lifetime `'a`, which does not appear in the trait input types
--> $DIR/ice-wf-missing-span-in-error-130012.rs:9:28
|
LL | trait MyTrait: for<'a> Fun<Assoc = &'a ()> {}
| ^^^^^^^^^^^^^^
|
= note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
error[E0582]: binding for associated type `Assoc` references lifetime `'a`, which does not appear in the trait input types
--> $DIR/ice-wf-missing-span-in-error-130012.rs:9:28
|
LL | trait MyTrait: for<'a> Fun<Assoc = &'a ()> {}
| ^^^^^^^^^^^^^^
|
= note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
error[E0582]: binding for associated type `Assoc` references lifetime `'b`, which does not appear in the trait input types
--> $DIR/ice-wf-missing-span-in-error-130012.rs:14:21
|
LL | impl<F: for<'b> Fun<Assoc = &'b ()>> MyTrait for F {}
| ^^^^^^^^^^^^^^
error[E0308]: mismatched types
--> $DIR/ice-wf-missing-span-in-error-130012.rs:14:50
|
LL | impl<F: for<'b> Fun<Assoc = &'b ()>> MyTrait for F {}
| ^ lifetime mismatch
|
= note: expected reference `&()`
found reference `&'b ()`
error: aborting due to 5 previous errors
Some errors have detailed explanations: E0308, E0582.
For more information about an error, try `rustc --explain E0308`.