mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #13096 - apoisternex:issue12954, r=y21

Browse Source 
fix [`excessive_precision`] suggestions on floats written in scientific notation

fixes #12954

changelog: fix [`excessive_precision`] suggestions on float literal written in scientific notation
This commit is contained in:
bors 2024-07-16 12:56:10 +00:00
commit 0ee9f44568
4 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clippy_utils/src/numeric_literal.rs
View File

@ -164,6 +164,8 @@ pub fn format(&self) -> String {
if !exponent.is_empty() && exponent != "0" { if !exponent.is_empty() && exponent != "0" {
output.push_str(separator); output.push_str(separator);
Self::group_digits(&mut output, exponent, group_size, true, false); Self::group_digits(&mut output, exponent, group_size, true, false);
} else if exponent == "0" && self.fraction.is_none() && self.suffix.is_none() {
output.push_str(".0");
} }
} }

4
tests/ui/excessive_precision.fixed
View File

@ -78,4 +78,8 @@ fn main() {
const NEG_INF1: f32 = -1.0e+33f32; const NEG_INF1: f32 = -1.0e+33f32;
const NEG_INF2: f64 = -1.0e+3300f64; const NEG_INF2: f64 = -1.0e+3300f64;
const NEG_INF3: f32 = -3.40282357e+38_f32; const NEG_INF3: f32 = -3.40282357e+38_f32;
// issue #12954
const _: f64 = 3.0;
const _: f64 = 3.0000000000000000;
} }

4
tests/ui/excessive_precision.rs
View File

@ -78,4 +78,8 @@ fn main() {
const NEG_INF1: f32 = -1.0e+33f32; const NEG_INF1: f32 = -1.0e+33f32;
const NEG_INF2: f64 = -1.0e+3300f64; const NEG_INF2: f64 = -1.0e+3300f64;
const NEG_INF3: f32 = -3.40282357e+38_f32; const NEG_INF3: f32 = -3.40282357e+38_f32;
// issue #12954
const _: f64 = 3.0000000000000000e+00;
const _: f64 = 3.0000000000000000;
} }

8
tests/ui/excessive_precision.stderr
View File

@ -91,5 +91,11 @@ error: float has excessive precision
LL | let _ = 1.000_000_000_000_001e-324_f64; LL | let _ = 1.000_000_000_000_001e-324_f64;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0_f64` | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0_f64`
error: aborting due to 15 previous errors error: float has excessive precision
--> tests/ui/excessive_precision.rs:83:20
|
LL | const _: f64 = 3.0000000000000000e+00;
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.0`
error: aborting due to 16 previous errors