mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use verbose for path separator suggestion

Browse Source
This commit is contained in:
Michael Goulet 2024-11-08 16:57:53 +00:00
parent 209799f3b9
commit 0e481b44f5
6 changed files with 104 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compiler/rustc_resolve/src/late/diagnostics.rs
View File

@ -1472,7 +1472,7 @@ fn smart_resolve_context_dependent_help(
}; };
if lhs_span.eq_ctxt(rhs_span) { if lhs_span.eq_ctxt(rhs_span) {
err.span_suggestion( err.span_suggestion_verbose(
lhs_span.between(rhs_span), lhs_span.between(rhs_span),
MESSAGE, MESSAGE,
"::", "::",

27
tests/ui/resolve/issue-100365.stderr
View File

@ -2,19 +2,34 @@ error[E0423]: expected value, found trait `Into`
--> $DIR/issue-100365.rs:2:16 --> $DIR/issue-100365.rs:2:16
| |
LL | let addr = Into::<std::net::IpAddr>.into([127, 0, 0, 1]); LL | let addr = Into::<std::net::IpAddr>.into([127, 0, 0, 1]);
| ^^^^^^^^^^^^^^^^^^^^^^^^- help: use the path separator to refer to an item: `::` | ^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use the path separator to refer to an item
|
LL | let addr = Into::<std::net::IpAddr>::into([127, 0, 0, 1]);
| ~~
error[E0423]: expected value, found trait `Into` error[E0423]: expected value, found trait `Into`
--> $DIR/issue-100365.rs:6:13 --> $DIR/issue-100365.rs:6:13
| |
LL | let _ = Into.into(()); LL | let _ = Into.into(());
| ^^^^- help: use the path separator to refer to an item: `::` | ^^^^
|
help: use the path separator to refer to an item
|
LL | let _ = Into::into(());
| ~~
error[E0423]: expected value, found trait `Into` error[E0423]: expected value, found trait `Into`
--> $DIR/issue-100365.rs:10:13 --> $DIR/issue-100365.rs:10:13
| |
LL | let _ = Into::<()>.into; LL | let _ = Into::<()>.into;
| ^^^^^^^^^^- help: use the path separator to refer to an item: `::` | ^^^^^^^^^^
|
help: use the path separator to refer to an item
|
LL | let _ = Into::<()>::into;
| ~~
error[E0423]: expected value, found trait `std::iter::Iterator` error[E0423]: expected value, found trait `std::iter::Iterator`
--> $DIR/issue-100365.rs:17:9 --> $DIR/issue-100365.rs:17:9
@ -42,12 +57,16 @@ error[E0423]: expected value, found trait `Into`
--> $DIR/issue-100365.rs:25:9 --> $DIR/issue-100365.rs:25:9
| |
LL | Into::<String>.into("") LL | Into::<String>.into("")
| ^^^^^^^^^^^^^^- help: use the path separator to refer to an item: `::` | ^^^^^^^^^^^^^^
... ...
LL | let _ = create!(); LL | let _ = create!();
| --------- in this macro invocation | --------- in this macro invocation
| |
= note: this error originates in the macro `create` (in Nightly builds, run with -Z macro-backtrace for more info) = note: this error originates in the macro `create` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use the path separator to refer to an item
|
LL | Into::<String>::into("")
| ~~
error: aborting due to 6 previous errors error: aborting due to 6 previous errors

33
tests/ui/resolve/issue-22692.stderr
View File

@ -2,19 +2,34 @@ error[E0423]: expected value, found struct `String`
--> $DIR/issue-22692.rs:2:13 --> $DIR/issue-22692.rs:2:13
| |
LL | let _ = String.new(); LL | let _ = String.new();
| ^^^^^^- help: use the path separator to refer to an item: `::` | ^^^^^^
|
help: use the path separator to refer to an item
|
LL | let _ = String::new();
| ~~
error[E0423]: expected value, found struct `String` error[E0423]: expected value, found struct `String`
--> $DIR/issue-22692.rs:6:13 --> $DIR/issue-22692.rs:6:13
| |
LL | let _ = String.default; LL | let _ = String.default;
| ^^^^^^- help: use the path separator to refer to an item: `::` | ^^^^^^
|
help: use the path separator to refer to an item
|
LL | let _ = String::default;
| ~~
error[E0423]: expected value, found struct `Vec` error[E0423]: expected value, found struct `Vec`
--> $DIR/issue-22692.rs:10:13 --> $DIR/issue-22692.rs:10:13
| |
LL | let _ = Vec::<()>.with_capacity(1); LL | let _ = Vec::<()>.with_capacity(1);
| ^^^^^^^^^- help: use the path separator to refer to an item: `::` | ^^^^^^^^^
|
help: use the path separator to refer to an item
|
LL | let _ = Vec::<()>::with_capacity(1);
| ~~
error[E0423]: expected value, found struct `std::cell::Cell` error[E0423]: expected value, found struct `std::cell::Cell`
--> $DIR/issue-22692.rs:17:9 --> $DIR/issue-22692.rs:17:9
@ -50,23 +65,31 @@ error[E0423]: expected value, found struct `Vec`
--> $DIR/issue-22692.rs:26:9 --> $DIR/issue-22692.rs:26:9
| |
LL | Vec.new() LL | Vec.new()
| ^^^- help: use the path separator to refer to an item: `::` | ^^^
... ...
LL | let _ = create!(type method); LL | let _ = create!(type method);
| -------------------- in this macro invocation | -------------------- in this macro invocation
| |
= note: this error originates in the macro `create` (in Nightly builds, run with -Z macro-backtrace for more info) = note: this error originates in the macro `create` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use the path separator to refer to an item
|
LL | Vec::new()
| ~~
error[E0423]: expected value, found struct `Vec` error[E0423]: expected value, found struct `Vec`
--> $DIR/issue-22692.rs:31:9 --> $DIR/issue-22692.rs:31:9
| |
LL | Vec.new LL | Vec.new
| ^^^- help: use the path separator to refer to an item: `::` | ^^^
... ...
LL | let _ = create!(type field); LL | let _ = create!(type field);
| ------------------- in this macro invocation | ------------------- in this macro invocation
| |
= note: this error originates in the macro `create` (in Nightly builds, run with -Z macro-backtrace for more info) = note: this error originates in the macro `create` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use the path separator to refer to an item
|
LL | Vec::new
| ~~
error[E0423]: expected value, found struct `std::cell::Cell` error[E0423]: expected value, found struct `std::cell::Cell`
--> $DIR/issue-22692.rs:17:9 --> $DIR/issue-22692.rs:17:9

14
tests/ui/resolve/suggest-path-for-tuple-struct.stderr
View File

@ -2,13 +2,23 @@ error[E0423]: expected value, found struct `SomeTupleStruct`
--> $DIR/suggest-path-for-tuple-struct.rs:22:13 --> $DIR/suggest-path-for-tuple-struct.rs:22:13
| |
LL | let _ = SomeTupleStruct.new(); LL | let _ = SomeTupleStruct.new();
| ^^^^^^^^^^^^^^^- help: use the path separator to refer to an item: `::` | ^^^^^^^^^^^^^^^
|
help: use the path separator to refer to an item
|
LL | let _ = SomeTupleStruct::new();
| ~~
error[E0423]: expected value, found struct `SomeRegularStruct` error[E0423]: expected value, found struct `SomeRegularStruct`
--> $DIR/suggest-path-for-tuple-struct.rs:24:13 --> $DIR/suggest-path-for-tuple-struct.rs:24:13
| |
LL | let _ = SomeRegularStruct.new(); LL | let _ = SomeRegularStruct.new();
| ^^^^^^^^^^^^^^^^^- help: use the path separator to refer to an item: `::` | ^^^^^^^^^^^^^^^^^
|
help: use the path separator to refer to an item
|
LL | let _ = SomeRegularStruct::new();
| ~~
error: aborting due to 2 previous errors error: aborting due to 2 previous errors

40
tests/ui/resolve/suggest-path-instead-of-mod-dot-item.stderr
View File

@ -2,19 +2,34 @@ error[E0423]: expected value, found module `a`
--> $DIR/suggest-path-instead-of-mod-dot-item.rs:17:5 --> $DIR/suggest-path-instead-of-mod-dot-item.rs:17:5
| |
LL | a.I LL | a.I
| ^- help: use the path separator to refer to an item: `::` | ^
|
help: use the path separator to refer to an item
|
LL | a::I
| ~~
error[E0423]: expected value, found module `a` error[E0423]: expected value, found module `a`
--> $DIR/suggest-path-instead-of-mod-dot-item.rs:23:5 --> $DIR/suggest-path-instead-of-mod-dot-item.rs:23:5
| |
LL | a.g() LL | a.g()
| ^- help: use the path separator to refer to an item: `::` | ^
|
help: use the path separator to refer to an item
|
LL | a::g()
| ~~
error[E0423]: expected value, found module `a` error[E0423]: expected value, found module `a`
--> $DIR/suggest-path-instead-of-mod-dot-item.rs:29:5 --> $DIR/suggest-path-instead-of-mod-dot-item.rs:29:5
| |
LL | a.b.J LL | a.b.J
| ^- help: use the path separator to refer to an item: `::` | ^
|
help: use the path separator to refer to an item
|
LL | a::b.J
| ~~
error[E0423]: expected value, found module `a::b` error[E0423]: expected value, found module `a::b`
--> $DIR/suggest-path-instead-of-mod-dot-item.rs:35:5 --> $DIR/suggest-path-instead-of-mod-dot-item.rs:35:5
@ -38,7 +53,12 @@ error[E0423]: expected value, found module `a`
--> $DIR/suggest-path-instead-of-mod-dot-item.rs:42:5 --> $DIR/suggest-path-instead-of-mod-dot-item.rs:42:5
| |
LL | a.b.f(); LL | a.b.f();
| ^- help: use the path separator to refer to an item: `::` | ^
|
help: use the path separator to refer to an item
|
LL | a::b.f();
| ~~
error[E0423]: expected value, found module `a::b` error[E0423]: expected value, found module `a::b`
--> $DIR/suggest-path-instead-of-mod-dot-item.rs:46:12 --> $DIR/suggest-path-instead-of-mod-dot-item.rs:46:12
@ -117,23 +137,31 @@ error[E0423]: expected value, found module `a`
--> $DIR/suggest-path-instead-of-mod-dot-item.rs:80:9 --> $DIR/suggest-path-instead-of-mod-dot-item.rs:80:9
| |
LL | a.f() LL | a.f()
| ^- help: use the path separator to refer to an item: `::` | ^
... ...
LL | let _ = create!(method); LL | let _ = create!(method);
| --------------- in this macro invocation | --------------- in this macro invocation
| |
= note: this error originates in the macro `create` (in Nightly builds, run with -Z macro-backtrace for more info) = note: this error originates in the macro `create` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use the path separator to refer to an item
|
LL | a::f()
| ~~
error[E0423]: expected value, found module `a` error[E0423]: expected value, found module `a`
--> $DIR/suggest-path-instead-of-mod-dot-item.rs:85:9 --> $DIR/suggest-path-instead-of-mod-dot-item.rs:85:9
| |
LL | a.f LL | a.f
| ^- help: use the path separator to refer to an item: `::` | ^
... ...
LL | let _ = create!(field); LL | let _ = create!(field);
| -------------- in this macro invocation | -------------- in this macro invocation
| |
= note: this error originates in the macro `create` (in Nightly builds, run with -Z macro-backtrace for more info) = note: this error originates in the macro `create` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use the path separator to refer to an item
|
LL | a::f
| ~~
error: aborting due to 13 previous errors error: aborting due to 13 previous errors

7
tests/ui/suggestions/assoc-const-as-field.stderr
View File

@ -2,7 +2,12 @@ error[E0423]: expected value, found struct `Mod::Foo`
--> $DIR/assoc-const-as-field.rs:11:9 --> $DIR/assoc-const-as-field.rs:11:9
| |
LL | foo(Mod::Foo.Bar); LL | foo(Mod::Foo.Bar);
| ^^^^^^^^- help: use the path separator to refer to an item: `::` | ^^^^^^^^
|
help: use the path separator to refer to an item
|
LL | foo(Mod::Foo::Bar);
| ~~
error: aborting due to 1 previous error error: aborting due to 1 previous error