mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix cast_abs_to_unsigned generates non-compiling code when original code is in parens

Browse Source
This commit is contained in:
alex-semenyuk 2022-07-30 17:21:37 +03:00
parent 580f642cfa
commit 0e1d65850a
4 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clippy_lints/src/casts/cast_abs_to_unsigned.rs
View File

@ -37,7 +37,7 @@ pub(super) fn check(
span,
&format!("casting the result of `{cast_from}::abs()` to {cast_to}"),
"replace with",
format!("{}.unsigned_abs()", Sugg::hir(cx, &args[0], "..")),
format!("{}.unsigned_abs()", Sugg::hir(cx, &args[0], "..").maybe_par()),
Applicability::MachineApplicable,
);
}

2
tests/ui/cast_abs_to_unsigned.fixed
View File

@ -26,4 +26,6 @@ fn main() {
let _ = a.unsigned_abs() as u32;
let _ = a.unsigned_abs() as u64;
let _ = a.unsigned_abs() as u128;
let _ = (x as i64 - y as i64).unsigned_abs() as u32;
}

2
tests/ui/cast_abs_to_unsigned.rs
View File

@ -26,4 +26,6 @@ fn main() {
let _ = a.abs() as u32;
let _ = a.abs() as u64;
let _ = a.abs() as u128;
let _ = (x as i64 - y as i64).abs() as u32;
}

8
tests/ui/cast_abs_to_unsigned.stderr
View File

@ -96,5 +96,11 @@ error: casting the result of `isize::abs()` to u128
LL | let _ = a.abs() as u128;
| ^^^^^^^ help: replace with: `a.unsigned_abs()`
error: aborting due to 16 previous errors
error: casting the result of `i64::abs()` to u32
--> $DIR/cast_abs_to_unsigned.rs:30:13
|
LL | let _ = (x as i64 - y as i64).abs() as u32;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(x as i64 - y as i64).unsigned_abs()`
error: aborting due to 17 previous errors