mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add comments for unnecessary_fallible_conversions

Browse Source
This commit is contained in:
roife 2024-01-01 16:28:34 +08:00
parent 69cc983155
commit 094ce3de3e
3 changed files with 12 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
clippy_lints/src/methods/unnecessary_fallible_conversions.rs
View File

@ -63,6 +63,7 @@ fn check<'tcx>(
}
});
// If there is an unwrap/expect call, extend the span to include the call
let span = if let Some(unwrap_call) = parent_unwrap_call {
primary_span.with_hi(unwrap_call.hi())
} else {

6
tests/ui/unnecessary_fallible_conversions.rs
View File

@ -10,10 +10,8 @@ fn main() {
let _: i64 = i32::try_into(0).unwrap();
let _: i64 = i32::try_into(0i32).expect("can't happen");
let _ = <i64 as TryFrom<i32>>::try_from(0)
.unwrap();
let _ = <i64 as TryFrom<i32>>::try_from(0).
expect("can't happen");
let _ = <i64 as TryFrom<i32>>::try_from(0).unwrap();
let _ = <i64 as TryFrom<i32>>::try_from(0).expect("can't happen");
let _: i64 = <i32 as TryInto<_>>::try_into(0).unwrap();
let _: i64 = <i32 as TryInto<_>>::try_into(0).expect("can't happen");

22
tests/ui/unnecessary_fallible_conversions.stderr
View File

@ -81,35 +81,31 @@ LL + let _: i64 = i32::into(0i32);
error: use of a fallible conversion when an infallible one could be used
--> $DIR/unnecessary_fallible_conversions.rs:13:13
|
LL | let _ = <i64 as TryFrom<i32>>::try_from(0)
| _____________^
LL | | .unwrap();
| |_________________^
LL | let _ = <i64 as TryFrom<i32>>::try_from(0).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: converting `i32` to `i64` cannot fail
help: use
|
LL - let _ = <i64 as TryFrom<i32>>::try_from(0)
LL - let _ = <i64 as TryFrom<i32>>::try_from(0).unwrap();
LL + let _ = <i64 as From<i32>>::from(0);
|
error: use of a fallible conversion when an infallible one could be used
--> $DIR/unnecessary_fallible_conversions.rs:15:13
--> $DIR/unnecessary_fallible_conversions.rs:14:13
|
LL | let _ = <i64 as TryFrom<i32>>::try_from(0).
| _____________^
LL | | expect("can't happen");
| |______________________________^
LL | let _ = <i64 as TryFrom<i32>>::try_from(0).expect("can't happen");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: converting `i32` to `i64` cannot fail
help: use
|
LL - let _ = <i64 as TryFrom<i32>>::try_from(0).
LL - let _ = <i64 as TryFrom<i32>>::try_from(0).expect("can't happen");
LL + let _ = <i64 as From<i32>>::from(0);
|
error: use of a fallible conversion when an infallible one could be used
--> $DIR/unnecessary_fallible_conversions.rs:18:18
--> $DIR/unnecessary_fallible_conversions.rs:16:18
|
LL | let _: i64 = <i32 as TryInto<_>>::try_into(0).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -122,7 +118,7 @@ LL + let _: i64 = <i32 as Into<_>>::into(0);
|
error: use of a fallible conversion when an infallible one could be used
--> $DIR/unnecessary_fallible_conversions.rs:19:18
--> $DIR/unnecessary_fallible_conversions.rs:17:18
|
LL | let _: i64 = <i32 as TryInto<_>>::try_into(0).expect("can't happen");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^