mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #121875 - estebank:e0277-drive-by, r=compiler-errors

Browse Source 
Account for unmet T: !Copy in E0277 message

```
error[E0277]: the trait bound `T: !Copy` is not satisfied
  --> $DIR/simple.rs:10:16
   |
LL |     not_copy::<T>();
   |                ^ the trait bound `T: !Copy` is not satisfied
```
instead of the current

```
error[E0277]: the trait bound `T: !Copy` is not satisfied
  --> $DIR/simple.rs:10:16
   |
LL |     not_copy::<T>();
   |                ^ the trait `!Copy` is not implemented for `T`
```
This commit is contained in:
Matthias Krüger 2024-03-02 10:09:38 +01:00 committed by GitHub
commit 07bd4590fb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
View File

@ -4752,20 +4752,21 @@ pub(super) fn get_explanation_based_on_obligation<'tcx>(
} else { } else {
String::new() String::new()
}; };
match ty_desc { let desc = match ty_desc {
Some(desc) => format!( Some(desc) => format!(" {desc}"),
"{}the trait `{}` is not implemented for {} `{}`{post}", None => String::new(),
pre_message, };
trait_predicate.print_modifiers_and_trait_path(), if let ty::ImplPolarity::Positive = trait_predicate.polarity() {
desc, format!(
tcx.short_ty_string(trait_ref.skip_binder().self_ty(), &mut None), "{pre_message}the trait `{}` is not implemented for{desc} `{}`{post}",
),
None => format!(
"{}the trait `{}` is not implemented for `{}`{post}",
pre_message,
trait_predicate.print_modifiers_and_trait_path(), trait_predicate.print_modifiers_and_trait_path(),
tcx.short_ty_string(trait_ref.skip_binder().self_ty(), &mut None), tcx.short_ty_string(trait_ref.skip_binder().self_ty(), &mut None),
), )
} else {
// "the trait bound `T: !Send` is not satisfied" reads better than "`!Send` is
// not implemented for `T`".
// FIXME: add note explaining explicit negative trait bounds.
format!("{pre_message}the trait bound `{trait_predicate}` is not satisfied{post}")
} }
} }
} }

8
tests/ui/traits/negative-bounds/simple.stderr
View File

@ -2,7 +2,7 @@ error[E0277]: the trait bound `T: !Copy` is not satisfied
--> $DIR/simple.rs:10:16 --> $DIR/simple.rs:10:16
| |
LL | not_copy::<T>(); LL | not_copy::<T>();
| ^ the trait `!Copy` is not implemented for `T` | ^ the trait bound `T: !Copy` is not satisfied
| |
note: required by a bound in `not_copy` note: required by a bound in `not_copy`
--> $DIR/simple.rs:3:16 --> $DIR/simple.rs:3:16
@ -14,7 +14,7 @@ error[E0277]: the trait bound `T: !Copy` is not satisfied
--> $DIR/simple.rs:15:16 --> $DIR/simple.rs:15:16
| |
LL | not_copy::<T>(); LL | not_copy::<T>();
| ^ the trait `!Copy` is not implemented for `T` | ^ the trait bound `T: !Copy` is not satisfied
| |
note: required by a bound in `not_copy` note: required by a bound in `not_copy`
--> $DIR/simple.rs:3:16 --> $DIR/simple.rs:3:16
@ -26,7 +26,7 @@ error[E0277]: the trait bound `Copyable: !Copy` is not satisfied
--> $DIR/simple.rs:30:16 --> $DIR/simple.rs:30:16
| |
LL | not_copy::<Copyable>(); LL | not_copy::<Copyable>();
| ^^^^^^^^ the trait `!Copy` is not implemented for `Copyable` | ^^^^^^^^ the trait bound `Copyable: !Copy` is not satisfied
| |
= help: the trait `Copy` is implemented for `Copyable` = help: the trait `Copy` is implemented for `Copyable`
note: required by a bound in `not_copy` note: required by a bound in `not_copy`
@ -44,7 +44,7 @@ error[E0277]: the trait bound `NotNecessarilyCopyable: !Copy` is not satisfied
--> $DIR/simple.rs:37:16 --> $DIR/simple.rs:37:16
| |
LL | not_copy::<NotNecessarilyCopyable>(); LL | not_copy::<NotNecessarilyCopyable>();
| ^^^^^^^^^^^^^^^^^^^^^^ the trait `!Copy` is not implemented for `NotNecessarilyCopyable` | ^^^^^^^^^^^^^^^^^^^^^^ the trait bound `NotNecessarilyCopyable: !Copy` is not satisfied
| |
note: required by a bound in `not_copy` note: required by a bound in `not_copy`
--> $DIR/simple.rs:3:16 --> $DIR/simple.rs:3:16