mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove last vestiges of skippng ident span hashing

Browse Source 
This removes a comment that no longer applies, and properly hashes
the full ident for path segments.
This commit is contained in:
Aaron Hill 2022-04-13 11:23:51 -04:00
parent f38c5c8e5d
commit 002a4e1bd5
No known key found for this signature in database
GPG Key ID: B4087E510E98B164
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compiler/rustc_ast/src/ast.rs
View File

@ -107,11 +107,11 @@ fn eq(&self, symbol: &Symbol) -> bool {
}
}
impl<CTX> HashStable<CTX> for Path {
impl<CTX: rustc_span::HashStableContext> HashStable<CTX> for Path {
fn hash_stable(&self, hcx: &mut CTX, hasher: &mut StableHasher) {
self.segments.len().hash_stable(hcx, hasher);
for segment in &self.segments {
segment.ident.name.hash_stable(hcx, hasher);
segment.ident.hash_stable(hcx, hasher);
}
}
}

10
compiler/rustc_span/src/hygiene.rs
View File

@ -103,16 +103,6 @@ impl !PartialOrd for LocalExpnId {}
/// of `HashingControls` settings.
fn assert_default_hashing_controls<CTX: HashStableContext>(ctx: &CTX, msg: &str) {
match ctx.hashing_controls() {
// Ideally, we would also check that `node_id_hashing_mode` was always
// `NodeIdHashingMode::HashDefPath`. However, we currently end up hashing
// `Span`s in this mode, and there's not an easy way to change that.
// All of the span-related data that we hash is pretty self-contained
// (in particular, we don't hash any `HirId`s), so this shouldn't result
// in any caching problems.
// FIXME: Enforce that we don't end up transitively hashing any `HirId`s,
// or ensure that this method is always invoked with the same
// `NodeIdHashingMode`
//
// Note that we require that `hash_spans` be set according to the global
// `-Z incremental-ignore-spans` option. Normally, this option is disabled,
// which will cause us to require that this method always be called with `Span` hashing