2019-08-24 02:23:06 -05:00
|
|
|
// run-rustfix
|
|
|
|
|
2018-07-28 10:34:52 -05:00
|
|
|
#[warn(clippy::cmp_owned)]
|
2019-08-24 02:23:06 -05:00
|
|
|
#[allow(clippy::unnecessary_operation, clippy::no_effect, unused_must_use, clippy::eq_op)]
|
2015-05-21 07:51:43 -05:00
|
|
|
fn main() {
|
2018-12-09 16:26:16 -06:00
|
|
|
fn with_to_string(x: &str) {
|
2015-10-12 17:46:05 -05:00
|
|
|
x != "foo".to_string();
|
2017-02-08 07:58:07 -06:00
|
|
|
|
2015-10-12 17:46:05 -05:00
|
|
|
"foo".to_string() != x;
|
2015-08-11 13:22:20 -05:00
|
|
|
}
|
2016-01-24 03:16:56 -06:00
|
|
|
|
|
|
|
let x = "oh";
|
|
|
|
|
2015-08-11 13:22:20 -05:00
|
|
|
with_to_string(x);
|
|
|
|
|
2017-02-08 07:58:07 -06:00
|
|
|
x != "foo".to_owned();
|
2015-08-11 13:22:20 -05:00
|
|
|
|
2017-02-08 07:58:07 -06:00
|
|
|
x != String::from("foo");
|
2016-01-18 08:35:50 -06:00
|
|
|
|
|
|
|
42.to_string() == "42";
|
2017-05-11 11:59:36 -05:00
|
|
|
|
|
|
|
Foo.to_owned() == Foo;
|
2018-10-08 21:04:29 -05:00
|
|
|
|
|
|
|
"abc".chars().filter(|c| c.to_owned() != 'X');
|
|
|
|
|
|
|
|
"abc".chars().filter(|c| *c != 'X');
|
2017-05-11 11:59:36 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
struct Foo;
|
|
|
|
|
|
|
|
impl PartialEq for Foo {
|
2019-08-24 02:23:06 -05:00
|
|
|
// Allow this here, because it emits the lint
|
|
|
|
// without a suggestion. This is tested in
|
2019-08-26 08:28:35 -05:00
|
|
|
// `tests/ui/cmp_owned/without_suggestion.rs`
|
2019-08-24 02:23:06 -05:00
|
|
|
#[allow(clippy::cmp_owned)]
|
2017-05-11 11:59:36 -05:00
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
self.to_owned() == *other
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl ToOwned for Foo {
|
|
|
|
type Owned = Bar;
|
|
|
|
fn to_owned(&self) -> Bar {
|
|
|
|
Bar
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-05-21 06:24:00 -05:00
|
|
|
#[derive(PartialEq, Eq)]
|
2017-05-11 11:59:36 -05:00
|
|
|
struct Bar;
|
|
|
|
|
|
|
|
impl PartialEq<Foo> for Bar {
|
|
|
|
fn eq(&self, _: &Foo) -> bool {
|
|
|
|
true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl std::borrow::Borrow<Foo> for Bar {
|
|
|
|
fn borrow(&self) -> &Foo {
|
|
|
|
static FOO: Foo = Foo;
|
|
|
|
&FOO
|
|
|
|
}
|
2015-05-21 07:51:43 -05:00
|
|
|
}
|
2018-10-09 21:25:03 -05:00
|
|
|
|
2022-05-21 06:24:00 -05:00
|
|
|
#[derive(PartialEq, Eq)]
|
2018-10-09 21:25:03 -05:00
|
|
|
struct Baz;
|
|
|
|
|
|
|
|
impl ToOwned for Baz {
|
|
|
|
type Owned = Baz;
|
|
|
|
fn to_owned(&self) -> Baz {
|
|
|
|
Baz
|
|
|
|
}
|
|
|
|
}
|