2020-08-12 11:26:51 -05:00
|
|
|
use syntax::{
|
2020-03-19 06:36:33 -05:00
|
|
|
ast::{self, AstNode},
|
|
|
|
T,
|
|
|
|
};
|
2019-11-21 12:51:40 -06:00
|
|
|
|
2020-05-06 11:45:35 -05:00
|
|
|
use crate::{
|
|
|
|
assist_context::{AssistContext, Assists},
|
|
|
|
utils::invert_boolean_expression,
|
2020-06-28 17:36:05 -05:00
|
|
|
AssistId, AssistKind,
|
2020-05-06 11:45:35 -05:00
|
|
|
};
|
2019-11-21 12:51:40 -06:00
|
|
|
|
|
|
|
// Assist: invert_if
|
|
|
|
//
|
|
|
|
// This transforms if expressions of the form `if !x {A} else {B}` into `if x {B} else {A}`
|
2021-07-31 07:47:44 -05:00
|
|
|
// This also works with `!=`. This assist can only be applied with the cursor on `if`.
|
2019-11-21 12:51:40 -06:00
|
|
|
//
|
|
|
|
// ```
|
|
|
|
// fn main() {
|
2021-01-06 14:15:48 -06:00
|
|
|
// if$0 !y { A } else { B }
|
2019-11-21 12:51:40 -06:00
|
|
|
// }
|
|
|
|
// ```
|
|
|
|
// ->
|
|
|
|
// ```
|
|
|
|
// fn main() {
|
2019-11-23 23:14:57 -06:00
|
|
|
// if y { B } else { A }
|
2019-11-21 12:51:40 -06:00
|
|
|
// }
|
|
|
|
// ```
|
2020-05-06 11:45:35 -05:00
|
|
|
pub(crate) fn invert_if(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
|
2020-11-06 15:21:56 -06:00
|
|
|
let if_keyword = ctx.find_token_syntax_at_offset(T![if])?;
|
2021-01-30 09:19:21 -06:00
|
|
|
let expr = ast::IfExpr::cast(if_keyword.parent()?)?;
|
2019-11-23 23:14:57 -06:00
|
|
|
let if_range = if_keyword.text_range();
|
2021-10-12 07:41:59 -05:00
|
|
|
let cursor_in_range = if_range.contains_range(ctx.selection_trimmed());
|
2019-11-21 12:51:40 -06:00
|
|
|
if !cursor_in_range {
|
|
|
|
return None;
|
|
|
|
}
|
|
|
|
|
2020-03-21 08:40:18 -05:00
|
|
|
// This assist should not apply for if-let.
|
2021-08-07 15:16:15 -05:00
|
|
|
if expr.condition()?.is_pattern_cond() {
|
2020-03-21 08:40:18 -05:00
|
|
|
return None;
|
|
|
|
}
|
|
|
|
|
2019-11-23 23:14:57 -06:00
|
|
|
let cond = expr.condition()?.expr()?;
|
2019-11-21 12:51:40 -06:00
|
|
|
let then_node = expr.then_branch()?.syntax().clone();
|
2020-05-06 11:45:35 -05:00
|
|
|
let else_block = match expr.else_branch()? {
|
|
|
|
ast::ElseBranch::Block(it) => it,
|
|
|
|
ast::ElseBranch::IfExpr(_) => return None,
|
|
|
|
};
|
2019-11-21 12:51:40 -06:00
|
|
|
|
2020-07-02 16:48:35 -05:00
|
|
|
acc.add(AssistId("invert_if", AssistKind::RefactorRewrite), "Invert if", if_range, |edit| {
|
2021-08-14 08:40:00 -05:00
|
|
|
let flip_cond = invert_boolean_expression(cond.clone());
|
2020-09-28 12:06:51 -05:00
|
|
|
edit.replace_ast(cond, flip_cond);
|
|
|
|
|
|
|
|
let else_node = else_block.syntax();
|
|
|
|
let else_range = else_node.text_range();
|
|
|
|
let then_range = then_node.text_range();
|
|
|
|
|
2020-05-06 11:45:35 -05:00
|
|
|
edit.replace(else_range, then_node.text());
|
|
|
|
edit.replace(then_range, else_node.text());
|
|
|
|
})
|
2019-11-23 23:14:57 -06:00
|
|
|
}
|
|
|
|
|
2019-11-21 12:51:40 -06:00
|
|
|
#[cfg(test)]
|
|
|
|
mod tests {
|
|
|
|
use super::*;
|
|
|
|
|
2020-05-06 03:16:55 -05:00
|
|
|
use crate::tests::{check_assist, check_assist_not_applicable};
|
2019-11-21 12:51:40 -06:00
|
|
|
|
2020-12-15 09:25:57 -06:00
|
|
|
#[test]
|
|
|
|
fn invert_if_composite_condition() {
|
|
|
|
check_assist(
|
|
|
|
invert_if,
|
2021-01-06 14:15:48 -06:00
|
|
|
"fn f() { i$0f x == 3 || x == 4 || x == 5 { 1 } else { 3 * 2 } }",
|
2020-12-15 09:25:57 -06:00
|
|
|
"fn f() { if !(x == 3 || x == 4 || x == 5) { 3 * 2 } else { 1 } }",
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
2020-12-21 10:37:38 -06:00
|
|
|
#[test]
|
|
|
|
fn invert_if_remove_not_parentheses() {
|
|
|
|
check_assist(
|
|
|
|
invert_if,
|
2021-01-06 14:15:48 -06:00
|
|
|
"fn f() { i$0f !(x == 3 || x == 4 || x == 5) { 3 * 2 } else { 1 } }",
|
2020-12-21 10:37:38 -06:00
|
|
|
"fn f() { if x == 3 || x == 4 || x == 5 { 1 } else { 3 * 2 } }",
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
2019-11-21 12:51:40 -06:00
|
|
|
#[test]
|
|
|
|
fn invert_if_remove_inequality() {
|
2019-11-21 13:18:22 -06:00
|
|
|
check_assist(
|
|
|
|
invert_if,
|
2021-01-06 14:15:48 -06:00
|
|
|
"fn f() { i$0f x != 3 { 1 } else { 3 + 2 } }",
|
2020-05-20 15:55:37 -05:00
|
|
|
"fn f() { if x == 3 { 3 + 2 } else { 1 } }",
|
2019-11-21 13:18:22 -06:00
|
|
|
)
|
2019-11-21 12:51:40 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn invert_if_remove_not() {
|
2019-11-21 13:18:22 -06:00
|
|
|
check_assist(
|
|
|
|
invert_if,
|
2021-01-06 14:15:48 -06:00
|
|
|
"fn f() { $0if !cond { 3 * 2 } else { 1 } }",
|
2020-05-20 15:55:37 -05:00
|
|
|
"fn f() { if cond { 1 } else { 3 * 2 } }",
|
2019-11-21 13:18:22 -06:00
|
|
|
)
|
2019-11-21 12:51:40 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2020-02-07 05:07:38 -06:00
|
|
|
fn invert_if_general_case() {
|
|
|
|
check_assist(
|
|
|
|
invert_if,
|
2021-01-06 14:15:48 -06:00
|
|
|
"fn f() { i$0f cond { 3 * 2 } else { 1 } }",
|
2020-05-20 15:55:37 -05:00
|
|
|
"fn f() { if !cond { 1 } else { 3 * 2 } }",
|
2020-02-07 05:07:38 -06:00
|
|
|
)
|
2019-11-21 12:51:40 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2020-02-07 05:07:38 -06:00
|
|
|
fn invert_if_doesnt_apply_with_cursor_not_on_if() {
|
2021-01-06 14:15:48 -06:00
|
|
|
check_assist_not_applicable(invert_if, "fn f() { if !$0cond { 3 * 2 } else { 1 } }")
|
2019-11-21 12:51:40 -06:00
|
|
|
}
|
2020-03-21 08:40:18 -05:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn invert_if_doesnt_apply_with_if_let() {
|
|
|
|
check_assist_not_applicable(
|
|
|
|
invert_if,
|
2021-01-06 14:15:48 -06:00
|
|
|
"fn f() { i$0f let Some(_) = Some(1) { 1 } else { 0 } }",
|
2020-03-21 08:40:18 -05:00
|
|
|
)
|
|
|
|
}
|
2020-08-23 15:30:07 -05:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn invert_if_option_case() {
|
|
|
|
check_assist(
|
|
|
|
invert_if,
|
2021-01-06 14:15:48 -06:00
|
|
|
"fn f() { if$0 doc_style.is_some() { Class::DocComment } else { Class::Comment } }",
|
2020-08-23 15:30:07 -05:00
|
|
|
"fn f() { if doc_style.is_none() { Class::Comment } else { Class::DocComment } }",
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn invert_if_result_case() {
|
|
|
|
check_assist(
|
|
|
|
invert_if,
|
2021-01-06 14:15:48 -06:00
|
|
|
"fn f() { i$0f doc_style.is_err() { Class::Err } else { Class::Ok } }",
|
2020-08-23 15:30:07 -05:00
|
|
|
"fn f() { if doc_style.is_ok() { Class::Ok } else { Class::Err } }",
|
|
|
|
)
|
|
|
|
}
|
2019-11-21 12:51:40 -06:00
|
|
|
}
|