mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
fd8aa5ec7d
rust/tests/ui/span/issue-23338-locals-die-before-temps-of-body.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

49 lines
2.0 KiB
Plaintext
Raw Normal View History

Add new error codes and update tests
2017-05-27 12:58:52 -05:00
error[E0597]: `y` does not live long enough
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/issue-23338-locals-die-before-temps-of-body.rs:10:5
improve "Doesn't live long enough" error
2016-10-14 10:55:45 -05:00
|
Account for method call and indexing when looking for inner-most path in expression
2023-01-16 20:52:43 -06:00
LL | let y = x;
| - binding `y` declared here
Update UI tests
2018-02-22 18:42:32 -06:00
LL | y.borrow().clone()
Use larger span for adjustments on method calls Currently, we use a relatively 'small' span for THIR expressions generated by an 'adjustment' (e.g. an autoderef, autoborrow, unsizing). As a result, if a borrow generated by an adustment ends up causing a borrowcheck error, for example: ```rust let mut my_var = String::new(); let my_ref = &my_var my_var.push('a'); my_ref; ``` then the span for the mutable borrow may end up referring to only the base expression (e.g. `my_var`), rather than the method call which triggered the mutable borrow (e.g. `my_var.push('a')`) Due to a quirk of the MIR borrowck implementation, this doesn't always get exposed in migration mode, but it does in many cases. This commit makes THIR building consistently use 'larger' spans for adjustment expressions The intent of this change it make it clearer to users when it's the specific way in which a variable is used (for example, in a method call) that produdes a borrowcheck error. For example, an error message claiming that a 'mutable borrow occurs here' might be confusing if it just points at a usage of a variable (e.g. `my_var`), when no `&mut` is in sight. Pointing at the entire expression should help to emphasize that the method call itself is responsible for the mutable borrow. In several cases, this makes the `#![feature(nll)]` diagnostic output match up exactly with the default (migration mode) output. As a result, several `.nll.stderr` files end up getting removed entirely.
2021-09-16 15:01:22 -05:00
| ^^^^^^^^^^
update tests for migrate mode by default
2019-04-22 02:40:08 -05:00
| |
| borrowed value does not live long enough
| a temporary with access to the borrow is created here ...
Update UI tests
2018-02-22 18:42:32 -06:00
LL | }
update tests for migrate mode by default
2019-04-22 02:40:08 -05:00
| -
| |
| `y` dropped here while still borrowed
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
| ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `Ref<'_, String>`
improve "Doesn't live long enough" error
2016-10-14 10:55:45 -05:00
|
Suggest `;` or assignment to drop borrows in tail exprs Address the diagnostics part of #70844. ``` error[E0597]: `counter` does not live long enough --> $DIR/issue-54556-niconii.rs:22:20 | LL | if let Ok(_) = counter.lock() { } | ^^^^^^^------- | | | borrowed value does not live long enough | a temporary with access to the borrow is created here ... ... LL | } | - | | | `counter` dropped here while still borrowed | ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `std::result::Result<MutexGuard<'_>, ()>` | help: consider adding semicolon after the expression so its temporaries are dropped sooner, before the local variables declared by the block are dropped | LL | if let Ok(_) = counter.lock() { }; | ^ ```
2020-04-16 14:43:40 -05:00
= note: the temporary is part of an expression at the end of a block;
consider forcing this temporary to be dropped sooner, before the block's local variables are dropped
help: for example, you could save the expression's value in a new local variable `x` and then make `x` be the expression at the end of the block
|
LL | let x = y.borrow().clone(); x
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 21:07:19 -05:00
| +++++++ +++
improve "Doesn't live long enough" error
2016-10-14 10:55:45 -05:00
Add new error codes and update tests
2017-05-27 12:58:52 -05:00
error[E0597]: `y` does not live long enough
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/issue-23338-locals-die-before-temps-of-body.rs:17:9
improve "Doesn't live long enough" error
2016-10-14 10:55:45 -05:00
|
Account for method call and indexing when looking for inner-most path in expression
2023-01-16 20:52:43 -06:00
LL | let y = x;
| - binding `y` declared here
Update UI tests
2018-02-22 18:42:32 -06:00
LL | y.borrow().clone()
Use larger span for adjustments on method calls Currently, we use a relatively 'small' span for THIR expressions generated by an 'adjustment' (e.g. an autoderef, autoborrow, unsizing). As a result, if a borrow generated by an adustment ends up causing a borrowcheck error, for example: ```rust let mut my_var = String::new(); let my_ref = &my_var my_var.push('a'); my_ref; ``` then the span for the mutable borrow may end up referring to only the base expression (e.g. `my_var`), rather than the method call which triggered the mutable borrow (e.g. `my_var.push('a')`) Due to a quirk of the MIR borrowck implementation, this doesn't always get exposed in migration mode, but it does in many cases. This commit makes THIR building consistently use 'larger' spans for adjustment expressions The intent of this change it make it clearer to users when it's the specific way in which a variable is used (for example, in a method call) that produdes a borrowcheck error. For example, an error message claiming that a 'mutable borrow occurs here' might be confusing if it just points at a usage of a variable (e.g. `my_var`), when no `&mut` is in sight. Pointing at the entire expression should help to emphasize that the method call itself is responsible for the mutable borrow. In several cases, this makes the `#![feature(nll)]` diagnostic output match up exactly with the default (migration mode) output. As a result, several `.nll.stderr` files end up getting removed entirely.
2021-09-16 15:01:22 -05:00
| ^^^^^^^^^^
update tests for migrate mode by default
2019-04-22 02:40:08 -05:00
| |
| borrowed value does not live long enough
| a temporary with access to the borrow is created here ...
Update UI tests
2018-02-22 18:42:32 -06:00
LL | };
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
| -- ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `Ref<'_, String>`
improve "Doesn't live long enough" error
2016-10-14 10:55:45 -05:00
| |
Improve "Doesn't live long enough" error case with different lifetime with spans
2016-10-26 11:10:39 -05:00
| `y` dropped here while still borrowed
update tests for migrate mode by default
2019-04-22 02:40:08 -05:00
|
Suggest `;` or assignment to drop borrows in tail exprs Address the diagnostics part of #70844. ``` error[E0597]: `counter` does not live long enough --> $DIR/issue-54556-niconii.rs:22:20 | LL | if let Ok(_) = counter.lock() { } | ^^^^^^^------- | | | borrowed value does not live long enough | a temporary with access to the borrow is created here ... ... LL | } | - | | | `counter` dropped here while still borrowed | ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `std::result::Result<MutexGuard<'_>, ()>` | help: consider adding semicolon after the expression so its temporaries are dropped sooner, before the local variables declared by the block are dropped | LL | if let Ok(_) = counter.lock() { }; | ^ ```
2020-04-16 14:43:40 -05:00
= note: the temporary is part of an expression at the end of a block;
consider forcing this temporary to be dropped sooner, before the block's local variables are dropped
help: for example, you could save the expression's value in a new local variable `x` and then make `x` be the expression at the end of the block
|
LL | let x = y.borrow().clone(); x
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 21:07:19 -05:00
| +++++++ +++
improve "Doesn't live long enough" error
2016-10-14 10:55:45 -05:00
Revert "Change error count messages" This reverts commit 5558c64f33446225739c1153b43d2e309bb4f50e.
2017-07-02 05:49:30 -05:00
error: aborting due to 2 previous errors
improve "Doesn't live long enough" error
2016-10-14 10:55:45 -05:00
update tests
2018-03-03 08:59:40 -06:00
For more information about this error, try `rustc --explain E0597`.
Reference in New Issue Copy Permalink